Add Docker setup for reproducible installation - #17
Open
alsolex wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a reproducible Docker-based install path for SatelliteSfM alongside the existing conda-based setup.
The Docker image was built and validated end-to-end on an A100 server using a JAX068 scene subset.
Changes
Dockerfile..dockerignoreto keep local data, outputs, caches, and Git metadata out of the build context.requirements.txt.preprocess_sfm/colmap_sfm_commands.pycompatible with both the legacy bundledColmapForVisSatand newer COLMAP builds:COLMAP_BINfrom an environment variable, the legacy path, thencolmaponPATH.max_errorflag fromcolmap exhaustive_matcher --help:SiftMatching.max_errorfor legacy COLMAP builds.TwoViewGeometry.max_errorfor newer COLMAP builds.Validation
CUDA_ARCHITECTURES=80.0.5px.Related issues
Addresses the installation-related parts of #9, #10, #11, and #12.
Notes
The Docker path is additive. The existing conda-based install path is kept unchanged.
The shared code changes are intended to preserve compatibility with existing installs while allowing users to run SatelliteSfM with either the legacy bundled
ColmapForVisSator a newer COLMAP binary.