Correct the determinism section of the snapshot spec - #46
Open
Maximilian-Nesslauer wants to merge 1 commit into
Open
Correct the determinism section of the snapshot spec#46Maximilian-Nesslauer wants to merge 1 commit into
Maximilian-Nesslauer wants to merge 1 commit into
Conversation
Maximilian-Nesslauer
added
area:index
MrJeranimo
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The section promised that an unchanged index keeps its ETag, and neither half of that held.
sourcescarries the two commit SHAs, so a commit that changes nothing the snapshot carries still moves the bytes, which is what the "no wall-clock field" rule exists to prevent.And writing the same bytes does not keep an ETag by itself, because publishing is a deployment and a deployment issues a new one either way.
States both halves instead, and adds the rule that the provenance follows the content rather than the clock.