Repository navigation
Try to stabilize AD tests by providing an RNG and using regular testset - #181
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #181 +/- ##
==========================================
+ Coverage 86.79% 88.62% +1.82%
==========================================
Files 36 36
Lines 3899 3946 +47
==========================================
+ Hits 3384 3497 +113
+ Misses 515 449 -66 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Jutho
approved these changes
Oct 20, 2026
Jutho
left a comment
Jutho
left a comment
Owner
There was a problem hiding this comment.
Looks good to me! Thanks for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think on newer Julia versions each testset is reseeding its own rng with a random seed. If we provide an rng this can be avoided so that the tests are more repeatable. Also swapped to regular
@testsetso the test counts are recorded overall.