Skip to content

Count the restart operator application in GMRES numops - #177

Merged
Jutho merged 1 commit into
Jutho:masterfrom
leburgel:lb/gmres-numops
Oct 11, 2026
Merged

Jutho merged 1 commit into
Jutho:masterfrom
leburgel:lb/gmres-numops

Conversation

@leburgel

Copy link
Copy Markdown
Contributor

At each GMRES restart, initialize! applies the operator once, but numops wasn't incremented for it, so info.numops came out one too low per restart. This PR adds the missing numops += 1. In one example (300×300, krylovdim = 20, maxiter = 100, not converged), GMRES reported 1903 operator applications where 2002 actually happened.

@codecov

codecov Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.63%. Comparing base (fdbbc11) to head (6f0934e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #177   +/-   ##
=======================================
  Coverage   86.62%   86.63%           
=======================================
  Files          36       36           
  Lines        3919     3920    +1     
=======================================
+ Hits         3395     3396    +1     
  Misses        524      524           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Jutho
Jutho merged commit 80dc683 into Jutho:master Oct 11, 2026
11 of 15 checks passed
@leburgel
leburgel deleted the lb/gmres-numops branch October 12, 2026 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants