Repository navigation
Count the restart operator application in GMRES numops - #177
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #177 +/- ##
=======================================
Coverage 86.62% 86.63%
=======================================
Files 36 36
Lines 3919 3920 +1
=======================================
+ Hits 3395 3396 +1
Misses 524 524 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lkdvos
approved these changes
Oct 11, 2026
Jutho
approved these changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At each GMRES restart,
initialize!applies the operator once, butnumopswasn't incremented for it, soinfo.numopscame out one too low per restart. This PR adds the missingnumops += 1. In one example (300×300,krylovdim = 20,maxiter = 100, not converged), GMRES reported 1903 operator applications where 2002 actually happened.