Adjust show method for fitted models #629
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #629 +/- ##
==========================================
+ Coverage 96.94% 96.98% +0.03%
==========================================
Files 8 8
Lines 1213 1229 +16
==========================================
+ Hits 1176 1192 +16
Misses 37 37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andreasnoack
force-pushed
the
an/fitshow
branch
3 times, most recently
from
98f3bbe to
e5e1feb
Compare
Only show the coefficients instead of the full coefficients table. At the time of the fitting, the user cannot pass arguments related to inference such as the level of the confidence interval, so it is better to only show this output when calling coeftable explicitly. Also, include the distribution family and link function when fitting glms as well as include the number of observations, the residual degrees of freedom and the residual deviance in the output. Adjust the show method to include MIME"text/plain" as it is producing "decorated" output. Finally, explicitly test the show method agaist reference output instead of just writing it to an IOBuffer.
andreasnoack
force-pushed
the
an/fitshow
branch
from
e5e1feb to
e3006f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only show the coefficients instead of the full coefficients table. At the time of the fitting, the user cannot pass arguments related to inference such as the level of the confidence interval, so it is better to only show this output when calling coeftable explicitly.
Also, include the distribution family and link function when fitting glms as well as include the number of observations, the residual degrees of freedom and the residual deviance in the output.
Adjust the show method to include MIME"text/plain" as it is producing "decorated" output. Finally, explicitly test the show method agaist reference output instead of just writing it to an IOBuffer.