Repository navigation
Make reused-tarball tests work on Julia 1.7 - #1460
Merged
eschnett merged 2 commits intoOct 20, 2026
Merged
Conversation
@test_throws accepts a message pattern only since Julia v1.8, so on the Julia 1.7 CI the five checks in "JLLs - reused tarballs" compared the regex to the exception and failed although the message matched. Add a small @test_throws_msg helper that matches the pattern against the printed error, which also covers the error wrapped in a CompositeException.
maleadt
approved these changes
Oct 20, 2026
maleadt
left a comment
maleadt
left a comment
Member
There was a problem hiding this comment.
LGTM. Small nit on the test macro.
Co-authored-by: Tim Besard <tim.besard@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out we are running CI still with Julia 1.7. This makes tests fail. The approach here is a band-aid to make them work. Another solution would be to update CI to run on Julia 1.10.
The Azure CI (Julia 1.7) has failed on
mastersince #1455:JLLs - reused tarballsreports 8 passed, 5 failed. The failures are the five@test_throws r"..."checks.@test_throwsaccepts a message pattern only since Julia 1.8; on 1.7 the regex is compared to the exception itself, so the checks fail even though the messages match. One of them (No usable build metadata) also gets an error wrapped in aCompositeException, which 1.8+ unwraps.This adds a small
@test_throws_msg pattern exprhelper totest/jll.jl, which matches the pattern againstsprint(showerror, err), and uses it for those five checks.Tested:
JLLs - reused tarballspasses on Julia 1.13 (13/13). On Julia 1.7.2 the helper passes for a matching plain error and a matching error wrapped byasyncmap, and fails when nothing is thrown or the message doesn't match.