Skip to content

Keep the libuv event loop alive during builds #1453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maleadt wants to merge 1 commit into from
Closed

Keep the libuv event loop alive during builds #1453

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/AutoBuild.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,21 @@ const BUILD_HELP = (
"""
)

# Julia 1.12 can lose the wakeup of the thread that services the libuv event
# loop when a worker thread arms IO (e.g. Pkg downloading artifacts in a
# `Threads.@spawn` task) while that thread is parked. The download then stalls
# forever with data waiting in the socket. Keeping a libuv handle active means
# the event loop never becomes idle, so thread 0 blocks inside `uv_run` instead
# of parking and picks up new watchers on its next iteration.
# See https://github.com/JuliaLang/julia/issues/63173.
const EVENT_LOOP_KEEPALIVE = Ref{Union{Nothing,Timer}}(nothing)
function keep_event_loop_alive()
if EVENT_LOOP_KEEPALIVE[] === nothing && Threads.nthreads() > 1
EVENT_LOOP_KEEPALIVE[] = Timer(_ -> nothing, 1; interval=1)
end
return nothing
end

"""
build_tarballs(ARGS, src_name, src_version, sources, script, platforms,
products, dependencies; kwargs...)
Expand Down Expand Up @@ -210,6 +225,8 @@ function build_tarballs(ARGS, src_name, src_version, sources, script,
return nothing
end

keep_event_loop_alive()

if compression_format != "gzip" && minimum_compat(julia_compat) < v"1.6"
error("Compression formats different from gzip are supported only from Julia v1.6, increase the Julia compat if you want to use a non-default format")
end
Expand Down
Loading