Repository navigation
Add unconditional top-level code blocks to generated JLLs - #1444
Merged
Merged
Conversation
Thread a toplevel_block keyword through metadata reconstruction and JLL generation, then emit it after wrapper selection in the generated module. Document its precompile-time semantics and keep it independent of platform augmentation, artifact selection, and JLLWrappers compatibility.
Exercise toplevel_block through JSON merging and generated-source ordering, then verify its definitions at runtime and from init code. Build a separate FreeBSD-only JLL to ensure the same definitions remain callable on a host where no artifact wrapper is available.
giordano
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
toplevel_blockkeyword tobuild_tarballsfor definitions that should be available unconditionally in a generated JLL module.The block is emitted after wrapper selection, so it can use
is_available(),host_platform, andproductsymbols when an artifact matches. Unlikeaugment_platform_block, it is not included in the artifact-selection subprocess and does not require changes to JLLWrappers or generated package dependencies.This is useful for JLLs that provide Julia-side APIs or metadata even on platforms where no artifact is available.