Added sizes, height and width Attributes to the PictureSource…#90
Added sizes, height and width Attributes to the PictureSource…#90majortom64 wants to merge 1 commit intoJohnSundell:masterfrom
sizes, height and width Attributes to the PictureSource…#90Conversation
JohnSundell
left a comment
There was a problem hiding this comment.
Looks great! Now just unit tests needed to get this mergable. Let me know if you want me to help out in any way.
|
@majortom64 can we close this PR, since these changes are also included in #91? Would make sense to review and merge them all as one change, I think. Then you could implement the unit tests for all new APIs within that PR, if you'd like. |
|
Trying to steal the glory of a PR from me?!? :-) I am pretty sure I did them as two because they were not part of the component (as they were used by the node), and it meant that they could be added separately. I am happy to have them all be part of the same PR, but if I have to do something on my end, I need instructions (git/GitHub) are still fairly new to me. I am almost done with the tests, BTW. Should have it all in today. |
|
@majortom64 No action needed from your side. I'll simply close this PR, and then you'll just push all of your future commits onto your other PR (#91). That is, the |
…Context.
This brings the PictureSourceContext in line with the standard.