Skip to content

test(compare): add type compiler validation tests for compare API#7359

Merged
JhaSourav07 merged 3 commits into
JhaSourav07:mainfrom
Tuba1809:test/compare-type-compiler
Jul 4, 2026
Merged

test(compare): add type compiler validation tests for compare API#7359
JhaSourav07 merged 3 commits into
JhaSourav07:mainfrom
Tuba1809:test/compare-type-compiler

Conversation

@Tuba1809

@Tuba1809 Tuba1809 commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes #6762

Added app/api/compare/route.type-compiler.test.ts to verify TypeScript compiler validation and schema constraints for the Compare API. The test suite covers:

  • Type inference for CompareParams
  • Compile-time validation of required parameter types
  • Schema validation for valid compare request parameters
  • Schema rejection for invalid parameter values
  • Optional parameter handling without compile-time or runtime errors

Pillar

  • 🎨 Pillar 1 — New Theme Design
  • 📐 Pillar 2 — Geometric SVG Improvement
  • 🕐 Pillar 3 — Timezone Logic Optimization
  • 🛠️ Other (Bug fix, refactoring, docs)

Visual Preview

N/A (test-only changes)

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally (localhost:3000/api/streak?user=YOUR_USERNAME).
  • I have run npm run format and npm run lint locally and resolved all errors (CI will fail otherwise).
  • My commits follow the Conventional Commits format (e.g., feat(themes): ..., fix(calculate): ...).
  • I have updated README.md if I added a new theme or URL parameter.
  • I have starred the repo.
  • I have made sure that I have only one commit to merge in this PR.
  • The SVG output matches the CommitPulse "premium quality" aesthetic standard (no raw elements, smooth animations, correct fonts).
  • (Recommended) I joined the CommitPulse Discord community for contributor discussions, mentorship, and faster PR support.

@github-actions github-actions Bot added the status:blocked This PR is blocked due to a failing CI check. label Jul 3, 2026
@github-actions github-actions Bot removed the status:blocked This PR is blocked due to a failing CI check. label Jul 4, 2026
@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Size Report (Gzipped Sizes)

✨ No significant bundle size changes detected.

📊 Summary of Totals

Category PR Size Base Size Difference
Total JS 3883.44 KB 3883.44 KB 0 B
Total CSS 323.09 KB 323.09 KB 0 B

@github-actions github-actions Bot added the type:testing Adding, updating, or fixing tests label Jul 4, 2026
@Aamod007 Aamod007 added mentor:Aamod007 level:beginner Small changes Usually isolated fixes or simple UI/text updates. quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. labels Jul 4, 2026

@Aamod007 Aamod007 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thanks for writing the TypeScript compiler tests for the compare API. Asserting CompareParams natively protects against downstream validation bugs.

I'm assigning level:beginner, type:testing, and quality:clean.

Excellent work, approving!

@JhaSourav07 JhaSourav07 added the gssoc:approved PR has been reviewed and accepted for valid contribution points label Jul 4, 2026
@JhaSourav07 JhaSourav07 merged commit 3b35dee into JhaSourav07:main Jul 4, 2026
8 checks passed
@github-actions github-actions Bot added this to the GSSoC 2026 milestone Jul 4, 2026
@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

🎉 Congratulations @Tuba1809! Your PR has been successfully merged. 🚀

Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.

⚠️ Important for GSSoC Contributors:
You are strictly advised to join our Discord Server as it is mandatory for all GSSoC participants. All important announcements, point claims, and community discussions happen there.

Keep building! 💻✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved PR has been reviewed and accepted for valid contribution points level:beginner Small changes Usually isolated fixes or simple UI/text updates. mentor:Aamod007 quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:testing Adding, updating, or fixing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(ApiCompareRoute-type-compiler): verify TypeScript Compiler Validation & Schema Constraints Stability (Variation 10)

3 participants