Cherry-pick "Fix classId for detecting protobuf enums" to 2.3.10 #5605
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The classId implied `Internal` as a package whereas it is a class instead. The test that verified that was using incorrect instance of `EnumLite` which caused compiler to behave weirdly instead of failing with missing class. Fixes: 195200551 Test: Compiler tests
ShikaSD
requested review from
a team,
andrewbailey,
bentrengrove,
chuckjaz and
derekxu16
as code owners
CristianGM
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The classId implied
Internalas a package whereas it is a class instead. The test that verified that was using incorrect instance ofEnumLitewhich caused compiler to behave weirdly instead of failing with missing class.Fixes: 195200551
Test: Compiler tests