fix(ci): make release tag push idempotent under concurrent runs#8
Merged
Conversation
When two CI runs race to push the same GitVersion tag, the loser's `git push` fails and aborts the job under `set -euo pipefail`. Now the push failure is caught, followed by a `git fetch --tags` verification: if the tag landed on the remote, the step succeeds; if the tag is genuinely absent, it still exits 1. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Code Coverage |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
=======================================
Coverage ? 98.06%
=======================================
Files ? 7
Lines ? 466
Branches ? 111
=======================================
Hits ? 457
Misses ? 9
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git push origin "v${PACKAGE_VERSION}"in a failure handler so concurrent CI runs pushing the same GitVersion tag no longer fail the jobProblem
Under
set -euo pipefail, two near-simultaneous CI runs onmainwith the same GitVersion tag will race. The loser'sgit pushreturns a non-zero exit code and aborts the entire job, producing a spurious CI failure for an otherwise-passing build.Test plan
mainCI run concludessuccess🤖 Generated with Claude Code