test: harden routing generator coverage#479
Merged
Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new TinyBDD generator test scenarios for the RoutingSlip and RecipientList source generators to cover previously untested branches: global-namespace partial struct hosts, mixed sync/async factory emission, escaped quote characters in generated names, and multiple invalid annotated methods producing repeated diagnostics.
Changes:
- Add global-struct + mixed sync/async + escaped-name scenarios for the RoutingSlip and RecipientList generators.
- Add multi-invalid-shape scenarios asserting one
PKRS003/PKRL003diagnostic per offending method.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/PatternKit.Generators.Tests/RoutingSlipGeneratorTests.cs | Adds global partial struct mixed sync/async test and invalid-step-shapes diagnostic test. |
| test/PatternKit.Generators.Tests/RecipientListGeneratorTests.cs | Adds global partial struct mixed sync/async test and invalid-recipient-shapes diagnostic test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Test Results 12 files 12 suites 11m 31s ⏱️ Results for commit 066a165. ♻️ This comment has been updated with latest results. |
Contributor
🔍 PR Validation ResultsVersion: `` ✅ Validation Steps
📊 ArtifactsDry-run artifacts have been uploaded and will be available for 7 days. This comment was automatically generated by the PR validation workflow. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #479 +/- ##
==========================================
+ Coverage 97.29% 97.39% +0.10%
==========================================
Files 579 579
Lines 47188 47191 +3
Branches 3076 6221 +3145
==========================================
+ Hits 45911 45963 +52
+ Misses 1277 1228 -49
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JerrettDavis
force-pushed
the
coverage/harden-generator-gaps-413-o
branch
from
35d0618 to
066a165
Compare
Contributor
Code Coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #413
Verification
RoutingSlipGeneratorTests|FullyQualifiedNameRecipientListGeneratorTests"