test(generators): cover transaction script and claim check#438
Merged
JerrettDavis merged 1 commit intoMay 30, 2026
Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds nested containing-type wrapper emission to the Transaction Script and Claim Check source generators (so generated factories can sit inside partial outer types) and significantly expands TinyBDD generator test coverage for invalid signatures, default names, host shape variants, escaped names, malformed type arguments, and nested hosts. Claim Check tests are also migrated onto the TinyBDD xUnit scenario base, and Transaction Script tests now compile/emit the generated output to catch regressions.
Changes:
- Refactor
TransactionScriptGeneratorandClaimCheckGeneratorto emit containing partial-type wrappers via sharedGetContainingTypes/AppendTypeDeclarationhelpers. - Greatly expand
ClaimCheckGeneratorTestsandTransactionScriptGeneratorTestswith theory-driven diagnostics, host shape, escaping, nesting, and malformed type-argument scenarios. - Have test compilation helpers emit the generated assembly and surface emit success/diagnostics through a new
GeneratorResultrecord.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/PatternKit.Generators/TransactionScript/TransactionScriptGenerator.cs | Emit containing partial type wrappers around generated Transaction Script factory. |
| src/PatternKit.Generators/Messaging/ClaimCheckGenerator.cs | Emit containing partial type wrappers around generated Claim Check factory. |
| test/PatternKit.Generators.Tests/TransactionScriptGeneratorTests.cs | Add invalid-signature theory rows, host shape, nested host, and malformed type-arg scenarios; assert emit success. |
| test/PatternKit.Generators.Tests/ClaimCheckGeneratorTests.cs | Migrate to TinyBDD xUnit base and add diagnostics theory, host shape, nested host, and malformed type-arg scenarios. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Test Results 12 files 12 suites 10m 22s ⏱️ Results for commit d3a014b. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #438 +/- ##
==========================================
+ Coverage 90.96% 96.48% +5.52%
==========================================
Files 551 551
Lines 44627 44667 +40
Branches 6426 6432 +6
==========================================
+ Hits 40595 43098 +2503
+ Misses 1682 1569 -113
+ Partials 2350 0 -2350
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
🔍 PR Validation ResultsVersion: `` ✅ Validation Steps
📊 ArtifactsDry-run artifacts have been uploaded and will be available for 7 days. This comment was automatically generated by the PR validation workflow. |
Contributor
Code Coverage |
JerrettDavis
deleted the
test/transaction-claimcheck-generator-coverage-413
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
TransactionScriptGeneratorTests|FullyQualifiedNameClaimCheckGeneratorTests" --logger "console;verbosity=minimal"Coverage
Refs #413