test: cover dynamic router and durable subscriber generators#433
Merged
JerrettDavis merged 1 commit intoMay 29, 2026
Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands coverage for the Messaging source generators by converting the Dynamic Router and Durable Subscriber generator tests to TinyBDD xUnit scenarios and adding scenarios for nested generator hosts (via containing-type wrapper emission) and additional invalid-declaration cases.
Changes:
- Update Dynamic Router and Durable Subscriber generators to emit containing partial type wrappers for nested generator hosts.
- Convert Dynamic Router and Durable Subscriber generator tests to TinyBDD xUnit scenario style and broaden diagnostic/shape/emit coverage.
- Extend abstractions attribute coverage to include new router/subscriber-related attributes and their constructor validation.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/PatternKit.Generators/Messaging/DynamicRouterGenerator.cs | Emits generated factory inside containing partial type wrappers for nested hosts. |
| src/PatternKit.Generators/Messaging/DurableSubscriberGenerator.cs | Same containing-type wrapper emission for durable subscriber factories. |
| test/PatternKit.Generators.Tests/DynamicRouterGeneratorTests.cs | Migrates to TinyBDD scenarios and adds coverage for invalid declarations, host shapes, nesting, and malformed type args. |
| test/PatternKit.Generators.Tests/DurableSubscriberGeneratorTests.cs | Migrates to TinyBDD scenarios and adds coverage for invalid declarations, defaults, host shapes, nesting, and malformed type args. |
| test/PatternKit.Generators.Tests/AbstractionsAttributeCoverageTests.cs | Adds coverage for new messaging attributes’ defaults and constructor validation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
251
to
253
| foreach (var route in routes) | ||
| sb.Append(" .When(@\"").Append(route.Name).Append("\", ").Append(route.Order).Append(", ").Append(route.PredicateMethodName).Append(").Then(").Append(route.HandlerMethodName).AppendLine(")"); | ||
| sb.Append(chainIndent).Append(" .When(@\"").Append(route.Name).Append("\", ").Append(route.Order).Append(", ").Append(route.PredicateMethodName).Append(").Then(").Append(route.HandlerMethodName).AppendLine(")"); | ||
|
|
Comment on lines
+285
to
+289
| sb.Append("abstract "); | ||
| else if (type.IsSealed && type.TypeKind == TypeKind.Class) | ||
| sb.Append("sealed "); | ||
| sb.Append("partial ").Append(type.TypeKind == TypeKind.Struct ? "struct" : "class").Append(' ').Append(type.Name); | ||
| } |
Comment on lines
+146
to
+150
| else if (type.IsAbstract && type.TypeKind == TypeKind.Class) | ||
| sb.Append("abstract "); | ||
| else if (type.IsSealed && type.TypeKind == TypeKind.Class) | ||
| sb.Append("sealed "); | ||
| sb.Append("partial ").Append(type.TypeKind == TypeKind.Struct ? "struct" : "class").Append(' ').Append(type.Name); |
Contributor
Test Results 12 files 12 suites 9m 41s ⏱️ Results for commit edc2c72. ♻️ This comment has been updated with latest results. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #433 +/- ##
==========================================
+ Coverage 90.38% 96.22% +5.83%
==========================================
Files 551 551
Lines 44392 44465 +73
Branches 6388 6402 +14
==========================================
+ Hits 40124 42786 +2662
+ Misses 1830 1679 -151
+ Partials 2438 0 -2438
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
🔍 PR Validation ResultsVersion: `` ✅ Validation Steps
📊 ArtifactsDry-run artifacts have been uploaded and will be available for 7 days. This comment was automatically generated by the PR validation workflow. |
JerrettDavis
force-pushed
the
test/messaging-router-subscriber-generator-coverage-413
branch
from
dd1ce9d to
edc2c72
Compare
Contributor
Code Coverage |
JerrettDavis
deleted the
test/messaging-router-subscriber-generator-coverage-413
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
DynamicRouterGeneratorTests|FullyQualifiedNameDurableSubscriberGeneratorTests|FullyQualifiedName~AbstractionsAttributeCoverageTests" --logger "console;verbosity=minimal"Coverage: DynamicRouterGenerator 97.9%; DurableSubscriberGenerator 97.1%; GenerateDynamicRouterAttribute/DynamicRouteAttribute/GenerateDurableSubscriberAttribute/DurableSubscriberHandlerAttribute 100%; PatternKit.Generators 95.6% locally.