test: cover repository generator hosts#432
Merged
Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull request overview
Expands the repository source generator to support nested host types by emitting wrapping partial declarations, and rewrites the generator test suite as TinyBDD scenarios that cover more invalid-input branches plus host-shape and emission-success assertions.
Changes:
- Emit containing-type partial wrappers (with indentation and accessibility) so
[GenerateRepository]works on nested types. - Refactor
GenerateSourceto share anAppendTypeDeclarationhelper between the host type and its containers. - Convert
RepositoryGeneratorTeststo TinyBDD[Scenario]tests covering invalid selectors, malformedtypeofarguments, default factory names, host shapes (abstract/sealed/struct), and nested hosts; add a sharedCompilehelper andGeneratorResultrecord that also verifies emit success.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/PatternKit.Generators/Repository/RepositoryGenerator.cs | Emit containing-type wrappers and refactor type-declaration emission into a helper with indentation support. |
| test/PatternKit.Generators.Tests/RepositoryGeneratorTests.cs | Rewrite tests as TinyBDD scenarios; broaden coverage to nested hosts, varied host shapes, malformed attribute args, and emission success. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Test Results 12 files 12 suites 9m 53s ⏱️ Results for commit 6a1814b. |
Contributor
Code Coverage |
Contributor
🔍 PR Validation ResultsVersion: `` ✅ Validation Steps
📊 ArtifactsDry-run artifacts have been uploaded and will be available for 7 days. This comment was automatically generated by the PR validation workflow. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #432 +/- ##
==========================================
+ Coverage 90.36% 96.14% +5.77%
==========================================
Files 551 551
Lines 44372 44392 +20
Branches 6385 6388 +3
==========================================
+ Hits 40097 42680 +2583
+ Misses 1836 1712 -124
+ Partials 2439 0 -2439
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Coverage: RepositoryGenerator 99.1%; PatternKit.Generators 95.6% locally.