Skip to content

test: cover pipes and filters generator hosts#424

Merged
JerrettDavis merged 1 commit into
mainfrom
test/pipes-filters-generator-coverage-413
May 29, 2026
Merged

test: cover pipes and filters generator hosts#424
JerrettDavis merged 1 commit into
mainfrom
test/pipes-filters-generator-coverage-413

Conversation

@JerrettDavis

Copy link
Copy Markdown
Owner

Summary

  • add TinyBDD coverage for PipesAndFilters pipeline defaults, escaped names, abstract/sealed/internal/struct hosts, malformed context arguments, and nested hosts
  • harden nested pipeline hosts by emitting containing partial type wrappers before the generated factory method
  • raise PipesAndFiltersPipelineGenerator source coverage from 84.2% to 98.8% in the generator-only report

Part of #413.

Validation

  • dotnet test test\PatternKit.Generators.Tests\PatternKit.Generators.Tests.csproj --configuration Release --framework net10.0 --filter "FullyQualifiedName~PipesAndFiltersPipelineGeneratorTests" --logger "console;verbosity=minimal"
  • dotnet test test\PatternKit.Generators.Tests\PatternKit.Generators.Tests.csproj --configuration Release --no-restore -p:TestTfmsInParallel=false --collect:"XPlat Code Coverage" --results-directory .\TestResults --logger "console;verbosity=minimal" -- DataCollectionRunSettings.DataCollectors.DataCollector.Configuration.Format=cobertura
  • dotnet tool run reportgenerator -reports:"TestResults*\coverage.cobertura.xml" -targetdir:"coverage-report-generators" -reporttypes:"TextSummary;Cobertura" -assemblyfilters:"+PatternKit.Generators" -filefilters:"-**/.Tests/;-/Tests/;-/obj/;-/bin/;-**/.g.cs"
  • dotnet format PatternKit.slnx --verify-no-changes --verbosity minimal
  • dotnet test test\PatternKit.Generators.Tests\PatternKit.Generators.Tests.csproj --configuration Release --no-restore --no-build -p:TestTfmsInParallel=false --logger "console;verbosity=minimal"

Copilot AI review requested due to automatic review settings May 29, 2026 17:32
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Deprecation Warning: The deny-licenses option is deprecated for possible removal in the next major release. For more information, see issue 997.

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds TinyBDD test coverage for the PipesAndFilters pipeline generator and hardens the generator to correctly emit nested containing type wrappers, raising source coverage from 84.2% to 98.8%.

Changes:

  • Emit containing partial type wrappers around the generated factory so nested hosts compile correctly.
  • Extract GetContainingTypes and AppendTypeDeclaration helpers (mirroring EventStoreGenerator).
  • Add TinyBDD scenarios covering defaults, host shapes, escaped pipeline names, nested accessibility variants, and malformed context arguments.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/PatternKit.Generators/Messaging/PipesAndFiltersPipelineGenerator.cs Adds nested type wrappers and refactors emission helpers.
test/PatternKit.Generators.Tests/PipesAndFiltersPipelineGeneratorTests.cs Adds scenarios for defaults, type shapes, nested wrappers, and malformed args.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions

Copy link
Copy Markdown
Contributor

Test Results

    12 files      12 suites   10m 15s ⏱️
 3 623 tests  3 623 ✅ 0 💤 0 ❌
10 880 runs  10 880 ✅ 0 💤 0 ❌

Results for commit 3bed222.

@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage

Summary
  Generated on: 05/29/2026 - 17:39:53
  Coverage date: 05/29/2026 - 17:37:24 - 05/29/2026 - 17:39:41
  Parser: MultiReport (12x Cobertura)
  Assemblies: 5
  Classes: 1616
  Files: 551
  Line coverage: 95.6%
  Covered lines: 42308
  Uncovered lines: 1917
  Coverable lines: 44225
  Total lines: 95456
  Branch coverage: 77.4% (12581 of 16237)
  Covered branches: 12581
  Total branches: 16237
  Method coverage: 96.4% (8356 of 8662)
  Full method coverage: 89.1% (7726 of 8662)
  Covered methods: 8356
  Fully covered methods: 7726
  Total methods: 8662

PatternKit.Core                                                                                                     95.4%
  PatternKit.Application.ActivityTracking.ActivityGateState                                                          100%
  PatternKit.Application.ActivityTracking.ActivityLease                                                              100%
  PatternKit.Application.ActivityTracking.ActivityRecord                                                             100%
  PatternKit.Application.ActivityTracking.ActivityTracker                                                            100%
  PatternKit.Application.Aggregates.AggregateCommandHandler<T1, T2, T3>                                              100%
  PatternKit.Application.Aggregates.AggregateCommandResult<T>                                                        100%
  PatternKit.Application.Aggregates.AggregateRoot<T1, T2>                                                            100%
  PatternKit.Application.AntiCorruption.AntiCorruptionLayer<T1, T2>                                                 90.4%
  PatternKit.Application.AntiCorruption.AntiCorruptionResult<T>                                                      100%
  PatternKit.Application.AuditLog.AuditLogAppendResult<T>                                                           85.7%
  PatternKit.Application.AuditLog.InMemoryAuditLog<T1, T2>                                                          95.4%
  PatternKit.Application.BoundedContexts.BoundedContextAdapter                                                       100%
  PatternKit.Application.BoundedContexts.BoundedContextCapability                                                   83.3%
  PatternKit.Application.BoundedContexts.BoundedContextDescriptor                                                   95.4%
  PatternKit.Application.ContextMaps.ContextMapDescriptor                                                           96.8%
  PatternKit.Application.ContextMaps.ContextMapRelationship                                                          100%
  PatternKit.Application.DataMapping.DataMapper<T1, T2>                                                             94.6%
  PatternKit.Application.DataMapping.DataMapperError                                                                  90%
  PatternKit.Application.DataMapping.DataMapperResult<T>                                                            84.6%
  PatternKit.Application.DomainEvents.DomainEventDispatcher<T>                                                      95.4%
  PatternKit.Application.DomainEvents.DomainEventDispatchResult                                                      100%
  PatternKit.Application.DomainServices.DomainServiceOperation<T1, T2>                                               100%
  PatternKit.Application.DomainServices.DomainServiceRegistry<T1, T2>                                                100%
  PatternKit.Application.EventSourcing.EventStoreAppendResult                                                        100%
  PatternKit.Application.EventSourcing.InMemoryEventStore<T1, T2>                                                   97.9%
  PatternKit.Application.EventSourcing.StoredEvent<T1, T2>                                                            80%
  PatternKit.Application.FeatureToggles.FeatureToggleDecision                                                       87.5%
  PatternKit.Application.FeatureToggles.FeatureToggleRule<T>                                                         100%
  PatternKit.Application.FeatureToggles.FeatureToggleSet<T>                                                         96.9%
  PatternKit.Application.IdentityMap.IdentityMap<T1, T2>                                                             100%
  PatternKit.Application.IdentityMap.IdentityMapResult<T>                                                           92.8%
  PatternKit.Application.MaterializedViews.MaterializedView<T1, T2>                                                 98.4%
  PatternKit.Application.Repository.InMemoryRepository<T1, T2>                                                      92.8%
  PatternKit.Application.Repository.RepositoryResult<T>                                                             93.3%
  PatternKit.Application.ServiceLayer.ServiceLayerOperation<T1, T2>                                                 96.7%
  PatternKit.Application.ServiceLayer.ServiceLayerResult<T>                                                         94.7%
  PatternKit.Application.ServiceLayer.ServiceLayerRule<T>                                                            100%
  PatternKit.Application.Specification.Specification<T>                                                              100%

@github-actions

Copy link
Copy Markdown
Contributor

🔍 PR Validation Results

Version: ``

✅ Validation Steps

  • Build solution
  • Run tests
  • Build documentation
  • Dry-run NuGet packaging

📊 Artifacts

Dry-run artifacts have been uploaded and will be available for 7 days.


This comment was automatically generated by the PR validation workflow.

@codecov

codecov Bot commented May 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.97%. Comparing base (ba737fb) to head (3bed222).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #424      +/-   ##
==========================================
+ Coverage   90.03%   95.97%   +5.93%     
==========================================
  Files         551      551              
  Lines       44205    44225      +20     
  Branches     6361     6364       +3     
==========================================
+ Hits        39800    42444    +2644     
+ Misses       1924     1781     -143     
+ Partials     2481        0    -2481     
Flag Coverage Δ
unittests 95.97% <100.00%> (+5.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JerrettDavis JerrettDavis merged commit 76a1f9a into main May 29, 2026
13 checks passed
@JerrettDavis JerrettDavis deleted the test/pipes-filters-generator-coverage-413 branch May 29, 2026 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants