test: cover factory generator edge cases#418
Merged
Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands the generator test suite to cover additional edge cases and previously-uncovered branches in FactoriesGenerator, supporting the coverage goals in #413.
Changes:
- Adds new TinyBDD scenarios for
FactoryMethodedge cases (empty hosts, default validation, duplicate/null keys, signature mismatch). - Adds new TinyBDD scenarios for
FactoryClassedge cases (abstract products, multi-base ambiguity, async factory creation fallback). - Extends internal helper assertions (unknown enum literals, null-key compatibility, accessibility formatting, async return formatting).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+335
to
+337
| [Scenario("FactoryMethod ValidatesDefaultsAndStringKeyComparer")] | ||
| [Fact] | ||
| public void FactoryMethod_ValidatesDefaultsAndStringKeyComparer() |
Comment on lines
+575
to
+577
| [Scenario("FactoryClass FlagsAbstractProductAndMultipleBases")] | ||
| [Fact] | ||
| public void FactoryClass_FlagsAbstractProductAndMultipleBases() |
Contributor
Code Coverage |
Contributor
Test Results 12 files 12 suites 10m 3s ⏱️ Results for commit e352cb2. |
Contributor
🔍 PR Validation ResultsVersion: `` ✅ Validation Steps
📊 ArtifactsDry-run artifacts have been uploaded and will be available for 7 days. This comment was automatically generated by the PR validation workflow. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #418 +/- ##
==========================================
+ Coverage 89.65% 95.75% +6.09%
==========================================
Files 551 551
Lines 44183 44183
Branches 6357 6357
==========================================
+ Hits 39614 42306 +2692
+ Misses 2048 1877 -171
+ Partials 2521 0 -2521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Coverage
Validation