build: baseline recommended analyzers#402
Merged
Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR establishes a supported static-analysis baseline for PatternKit production package projects while preserving source-generator workspace compatibility for examples and benchmarks.
Changes:
- Enables built-in .NET analyzers in
Recommendedmode for selected production projects. - Adds path-scoped
.editorconfigsuppressions for the current analyzer baseline. - Pins benchmark source-generator analyzer references to
netstandard2.0and documents quality-gate expectations.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Directory.Build.props |
Adds analyzer settings for production package projects. |
.editorconfig |
Adds path-scoped CA analyzer baseline suppressions. |
benchmarks/PatternKit.Benchmarks/PatternKit.Benchmarks.csproj |
Pins the generator analyzer project reference to netstandard2.0. |
docs/guides/quality-gates.md |
Documents analyzer policy, validation gates, and source-generator workspace constraints. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Test Results 12 files 12 suites 9m 55s ⏱️ Results for commit 2c90a41. ♻️ This comment has been updated with latest results. |
Contributor
🔍 PR Validation ResultsVersion: `` ✅ Validation Steps
📊 ArtifactsDry-run artifacts have been uploaded and will be available for 7 days. This comment was automatically generated by the PR validation workflow. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #402 +/- ##
==========================================
+ Coverage 89.56% 95.63% +6.07%
==========================================
Files 530 530
Lines 42899 42899
Branches 6203 6203
==========================================
+ Hits 38423 41027 +2604
+ Misses 2023 1872 -151
+ Partials 2453 0 -2453
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JerrettDavis
changed the title
JerrettDavis
force-pushed
the
fix/analyzer-workspace-loading
branch
from
d069ab8 to
532693d
Compare
JerrettDavis
force-pushed
the
fix/analyzer-workspace-loading
branch
from
532693d to
2c90a41
Compare
Contributor
Code Coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EnforceCodeStyleInBuildout of the solution pathCloses #398.
Closes #399.
Validation
dotnet format PatternKit.slnx --verify-no-changes --verbosity minimaldotnet build PatternKit.slnx --configuration Release --no-restore -m:1dotnet test PatternKit.slnx --configuration Release --no-build -p:TestTfmsInParallel=false --logger "console;verbosity=minimal"docfx docs\docfx.json --warningsAsErrors