fix: use ordinal generator string comparisons

[JerrettDavis]

Summary

• replace culture-sensitive generator string prefix checks with ordinal comparisons
• use invariant conversions for generator enum and parameter-name normalization paths
• update generator tests to use ordinal generated-source ordering and diagnostic-prefix checks

Validation

• dotnet format PatternKit.slnx --verify-no-changes --verbosity minimal
• dotnet build src\PatternKit.Generators\PatternKit.Generators.csproj --configuration Release --no-restore /p:EnableNETAnalyzers=true /p:AnalysisLevel=latest /p:AnalysisMode=Recommended /p:EnforceCodeStyleInBuild=true
• dotnet test test\PatternKit.Generators.Tests\PatternKit.Generators.Tests.csproj --configuration Release --framework net8.0 --logger "console;verbosity=minimal"
• dotnet build PatternKit.slnx --configuration Release --no-restore -m:1

Part of #399.

[github-actions]

⚠️ Deprecation Warning: The deny-licenses option is deprecated for possible removal in the next major release. For more information, see issue 997.

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

[Copilot]

Pull request overview

This PR hardens source-generator code and tests by replacing culture-sensitive string operations with ordinal comparisons and invariant casing/conversion where generator behavior should be deterministic across cultures.

Changes:

• Updated generator prefix checks and async/task type detection to use StringComparison.Ordinal.
• Switched enum constant conversion and parameter-name normalization to invariant culture APIs.
• Adjusted generator tests to use ordinal ordering and diagnostic-prefix checks.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/PatternKit.Generators/ComposerGenerator.cs	Uses ordinal prefix checks for Func<>, Task<>, and ValueTask<> detection.
src/PatternKit.Generators/DecoratorGenerator.cs	Uses ordinal prefix checks for interface-name and async-return detection.
src/PatternKit.Generators/FacadeGenerator.cs	Uses ordinal prefix checks for generated names, async return handling, and field-name normalization.
src/PatternKit.Generators/PrototypeGenerator.cs	Uses ordinal prefix check for immutable collection type detection.
src/PatternKit.Generators/ProxyGenerator.cs	Uses ordinal prefix checks and invariant parameter-name casing.
src/PatternKit.Generators/Singleton/SingletonGenerator.cs	Uses ordinal prefix check when normalizing verbatim identifiers.
src/PatternKit.Generators/StateMachineGenerator.cs	Uses invariant culture for enum constant conversions.
src/PatternKit.Generators/VisitorGenerator.cs	Uses ordinal prefix check for default visitor interface naming.
test/PatternKit.Generators.Tests/DecoratorGeneratorTests.cs	Uses ordinal source ordering checks.
test/PatternKit.Generators.Tests/DispatcherGeneratorTests.cs	Uses ordinal error-prefix check.
test/PatternKit.Generators.Tests/FacadeGeneratorTests.cs	Uses ordinal source ordering checks.
test/PatternKit.Generators.Tests/StateMachineGeneratorTests.cs	Uses ordinal source ordering and diagnostic-prefix checks.
test/PatternKit.Generators.Tests/TemplateGeneratorTests.cs	Uses ordinal generated-source ordering checks.
test/PatternKit.Generators.Tests/VisitorGeneratorTests.cs	Uses ordinal diagnostic-prefix check.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

Test Results

    12 files      12 suites   9m 17s ⏱️
 3 513 tests  3 513 ✅ 0 💤 0 ❌
10 550 runs  10 550 ✅ 0 💤 0 ❌

Results for commit aa4116a.

[github-actions]

Code Coverage

Summary
  Generated on: 05/28/2026 - 02:00:37
  Coverage date: 05/28/2026 - 01:58:13 - 05/28/2026 - 02:00:25
  Parser: MultiReport (12x Cobertura)
  Assemblies: 5
  Classes: 1613
  Files: 649
  Line coverage: 94.6%
  Covered lines: 42062
  Uncovered lines: 2387
  Coverable lines: 44449
  Total lines: 97120
  Branch coverage: 75.5% (12371 of 16380)
  Covered branches: 12371
  Total branches: 16380
  Method coverage: 96% (8425 of 8770)
  Full method coverage: 88.1% (7731 of 8770)
  Covered methods: 8425
  Fully covered methods: 7731
  Total methods: 8770

PatternKit.Core                                                                                                     95.4%
  PatternKit.Application.ActivityTracking.ActivityGateState                                                          100%
  PatternKit.Application.ActivityTracking.ActivityLease                                                              100%
  PatternKit.Application.ActivityTracking.ActivityRecord                                                             100%
  PatternKit.Application.ActivityTracking.ActivityTracker                                                            100%
  PatternKit.Application.AntiCorruption.AntiCorruptionLayer<T1, T2>                                                 90.4%
  PatternKit.Application.AntiCorruption.AntiCorruptionResult<T>                                                      100%
  PatternKit.Application.AuditLog.AuditLogAppendResult<T>                                                           85.7%
  PatternKit.Application.AuditLog.InMemoryAuditLog<T1, T2>                                                          95.4%
  PatternKit.Application.DataMapping.DataMapper<T1, T2>                                                             94.6%
  PatternKit.Application.DataMapping.DataMapperError                                                                  90%
  PatternKit.Application.DataMapping.DataMapperResult<T>                                                            84.6%
  PatternKit.Application.DomainEvents.DomainEventDispatcher<T>                                                      95.4%
  PatternKit.Application.DomainEvents.DomainEventDispatchResult                                                      100%
  PatternKit.Application.EventSourcing.EventStoreAppendResult                                                        100%
  PatternKit.Application.EventSourcing.InMemoryEventStore<T1, T2>                                                   97.9%
  PatternKit.Application.EventSourcing.StoredEvent<T1, T2>                                                            80%
  PatternKit.Application.FeatureToggles.FeatureToggleDecision                                                       87.5%
  PatternKit.Application.FeatureToggles.FeatureToggleRule<T>                                                         100%
  PatternKit.Application.FeatureToggles.FeatureToggleSet<T>                                                         96.9%
  PatternKit.Application.IdentityMap.IdentityMap<T1, T2>                                                             100%
  PatternKit.Application.IdentityMap.IdentityMapResult<T>                                                           92.8%
  PatternKit.Application.MaterializedViews.MaterializedView<T1, T2>                                                 98.4%
  PatternKit.Application.Repository.InMemoryRepository<T1, T2>                                                      92.8%
  PatternKit.Application.Repository.RepositoryResult<T>                                                             93.3%
  PatternKit.Application.ServiceLayer.ServiceLayerOperation<T1, T2>                                                 96.7%
  PatternKit.Application.ServiceLayer.ServiceLayerResult<T>                                                         94.7%
  PatternKit.Application.ServiceLayer.ServiceLayerRule<T>                                                            100%
  PatternKit.Application.Specification.Specification<T>                                                              100%
  PatternKit.Application.Specification.SpecificationRegistry<T>                                                     93.3%
  PatternKit.Application.TableDataGateway.InMemoryTableDataGateway<T1, T2>                                            86%
  PatternKit.Application.TableDataGateway.TableGatewayResult<T>                                                     82.3%
  PatternKit.Application.TransactionScript.TransactionScript<T1, T2>                                                  97%
  PatternKit.Application.TransactionScript.TransactionScriptError                                                     90%
  PatternKit.Application.TransactionScript.TransactionScriptResult<T>                                                100%
  PatternKit.Application.UnitOfWork.UnitOfWork                                                                      90.9%
  PatternKit.Application.UnitOfWork.UnitOfWorkResult                                                                94.7%
  PatternKit.Application.UnitOfWork.UnitOfWorkRollbackResult                                                         100%
  PatternKit.Application.UnitOfWork.UnitOfWorkStep                                                                   100%

[github-actions]

🔍 PR Validation Results

Version: ``

✅ Validation Steps

• Build solution
• Run tests
• Build documentation
• Dry-run NuGet packaging

📊 Artifacts

Dry-run artifacts have been uploaded and will be available for 7 days.

---

This comment was automatically generated by the PR validation workflow.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.63%. Comparing base (8c7306c) to head (aa4116a).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #401      +/-   ##
==========================================
+ Coverage   89.55%   95.63%   +6.07%     
==========================================
  Files         530      530              
  Lines       42899    42899              
  Branches     6203     6203              
==========================================
+ Hits        38420    41026    +2606     
+ Misses       2022     1873     -149     
+ Partials     2457        0    -2457     

Flag	Coverage Δ
unittests	95.63% <100.00%> (+6.07%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.