Skip to content

fix(ci): allow dependency commit format in conventional commit checks#371

Merged
JerrettDavis merged 3 commits into
mainfrom
copilot/fix-dependencies-and-conventional-commit
May 27, 2026
Merged

fix(ci): allow dependency commit format in conventional commit checks#371
JerrettDavis merged 3 commits into
mainfrom
copilot/fix-dependencies-and-conventional-commit

Conversation

Copilot AI commented May 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • allow deps as an accepted conventional-commit type in the Conventional Commits workflow
  • update Dependabot NuGet commit-message prefix from deps to chore (with scope) so future dependency PRs are generated in conventional format

Validation

  • dotnet restore --use-lock-file
  • dotnet tool restore
  • dotnet build PatternKit.slnx --configuration Release --no-restore /p:ContinuousIntegrationBuild=true
  • dotnet test PatternKit.slnx --configuration Release --no-build --verbosity minimal
  • codeql_checker (actions): 0 alerts

Copilot AI self-assigned this May 26, 2026
Copilot AI review requested due to automatic review settings May 26, 2026 15:40
Copilot AI removed the request for review from Copilot May 26, 2026 15:40
Copilot AI requested a review from JerrettDavis May 26, 2026 15:42
@JerrettDavis JerrettDavis marked this pull request as ready for review May 27, 2026 01:41
Copilot AI review requested due to automatic review settings May 27, 2026 01:41
@github-actions

github-actions Bot commented May 27, 2026

Copy link
Copy Markdown
Contributor

⚠️ Deprecation Warning: The deny-licenses option is deprecated for possible removal in the next major release. For more information, see issue 997.

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates repository CI configuration so Conventional Commit validation accepts deps as a valid type, and adjusts Dependabot’s NuGet commit message prefix to generate Conventional Commit–compliant subjects going forward.

Changes:

  • Extend Conventional Commits workflow validation to accept the deps type (regex + error message guidance).
  • Change Dependabot NuGet commit-message prefix from deps to chore (with scope).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/conventional-commits.yml Adds deps to the allowed Conventional Commit types for PR titles and commit subjects.
.github/dependabot.yml Updates Dependabot’s NuGet commit message prefix to chore while keeping include: scope for Conventional Commit formatting.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions

github-actions Bot commented May 27, 2026

Copy link
Copy Markdown
Contributor

Test Results

    1 files      1 suites   2m 50s ⏱️
1 028 tests 1 028 ✅ 0 💤 0 ❌
1 033 runs  1 033 ✅ 0 💤 0 ❌

Results for commit ca61cc6.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented May 27, 2026

Copy link
Copy Markdown
Contributor

🔍 PR Validation Results

Version: ``

✅ Validation Steps

  • Build solution
  • Run tests
  • Build documentation
  • Dry-run NuGet packaging

📊 Artifacts

Dry-run artifacts have been uploaded and will be available for 7 days.


This comment was automatically generated by the PR validation workflow.

@codecov

codecov Bot commented May 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.61%. Comparing base (f12caf1) to head (ca61cc6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #371      +/-   ##
==========================================
+ Coverage   89.59%   95.61%   +6.01%     
==========================================
  Files         506      506              
  Lines       41377    41377              
  Branches     5972     5972              
==========================================
+ Hits        37072    39562    +2490     
+ Misses       1960     1815     -145     
+ Partials     2345        0    -2345     
Flag Coverage Δ
unittests 95.61% <ø> (+6.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage

Summary
  Generated on: 05/27/2026 - 02:27:03
  Coverage date: 05/27/2026 - 02:25:38 - 05/27/2026 - 02:26:51
  Parser: MultiReport (9x Cobertura)
  Assemblies: 4
  Classes: 1536
  Files: 618
  Line coverage: 94.5%
  Covered lines: 40572
  Uncovered lines: 2326
  Coverable lines: 42898
  Total lines: 94015
  Branch coverage: 75.5% (11950 of 15808)
  Covered branches: 11950
  Total branches: 15808
  Method coverage: 95.9% (8119 of 8460)
  Full method coverage: 88.1% (7458 of 8460)
  Covered methods: 8119
  Fully covered methods: 7458
  Total methods: 8460

PatternKit.Core                                                                                                     95.4%
  PatternKit.Application.ActivityTracking.ActivityGateState                                                          100%
  PatternKit.Application.ActivityTracking.ActivityLease                                                              100%
  PatternKit.Application.ActivityTracking.ActivityRecord                                                             100%
  PatternKit.Application.ActivityTracking.ActivityTracker                                                            100%
  PatternKit.Application.AntiCorruption.AntiCorruptionLayer<T1, T2>                                                 90.4%
  PatternKit.Application.AntiCorruption.AntiCorruptionResult<T>                                                      100%
  PatternKit.Application.AuditLog.AuditLogAppendResult<T>                                                           85.7%
  PatternKit.Application.AuditLog.InMemoryAuditLog<T1, T2>                                                          95.4%
  PatternKit.Application.DataMapping.DataMapper<T1, T2>                                                             94.6%
  PatternKit.Application.DataMapping.DataMapperError                                                                  90%
  PatternKit.Application.DataMapping.DataMapperResult<T>                                                            84.6%
  PatternKit.Application.DomainEvents.DomainEventDispatcher<T>                                                      95.4%
  PatternKit.Application.DomainEvents.DomainEventDispatchResult                                                      100%
  PatternKit.Application.EventSourcing.EventStoreAppendResult                                                        100%
  PatternKit.Application.EventSourcing.InMemoryEventStore<T1, T2>                                                   97.9%
  PatternKit.Application.EventSourcing.StoredEvent<T1, T2>                                                            80%
  PatternKit.Application.FeatureToggles.FeatureToggleDecision                                                       87.5%
  PatternKit.Application.FeatureToggles.FeatureToggleRule<T>                                                         100%
  PatternKit.Application.FeatureToggles.FeatureToggleSet<T>                                                         96.9%
  PatternKit.Application.IdentityMap.IdentityMap<T1, T2>                                                             100%
  PatternKit.Application.IdentityMap.IdentityMapResult<T>                                                           92.8%
  PatternKit.Application.MaterializedViews.MaterializedView<T1, T2>                                                 98.4%
  PatternKit.Application.Repository.InMemoryRepository<T1, T2>                                                      92.8%
  PatternKit.Application.Repository.RepositoryResult<T>                                                             93.3%
  PatternKit.Application.ServiceLayer.ServiceLayerOperation<T1, T2>                                                 96.7%
  PatternKit.Application.ServiceLayer.ServiceLayerResult<T>                                                         94.7%
  PatternKit.Application.ServiceLayer.ServiceLayerRule<T>                                                            100%
  PatternKit.Application.Specification.Specification<T>                                                              100%
  PatternKit.Application.Specification.SpecificationRegistry<T>                                                     93.3%
  PatternKit.Application.TableDataGateway.InMemoryTableDataGateway<T1, T2>                                            86%
  PatternKit.Application.TableDataGateway.TableGatewayResult<T>                                                     82.3%
  PatternKit.Application.TransactionScript.TransactionScript<T1, T2>                                                  97%
  PatternKit.Application.TransactionScript.TransactionScriptError                                                     90%
  PatternKit.Application.TransactionScript.TransactionScriptResult<T>                                                100%
  PatternKit.Application.UnitOfWork.UnitOfWork                                                                      90.9%
  PatternKit.Application.UnitOfWork.UnitOfWorkResult                                                                94.7%
  PatternKit.Application.UnitOfWork.UnitOfWorkRollbackResult                                                         100%
  PatternKit.Application.UnitOfWork.UnitOfWorkStep                                                                   100%

@JerrettDavis JerrettDavis merged commit dea38a6 into main May 27, 2026
12 checks passed
@JerrettDavis JerrettDavis deleted the copilot/fix-dependencies-and-conventional-commit branch May 27, 2026 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants