Add LRU cache for JSONPointerToSlice and DotPathToSlice.#136
Open
nibbleshift wants to merge 4 commits intoJeffail:masterfrom
Open
Add LRU cache for JSONPointerToSlice and DotPathToSlice.#136nibbleshift wants to merge 4 commits intoJeffail:masterfrom
nibbleshift wants to merge 4 commits intoJeffail:masterfrom
Conversation
Signed-off-by: Steve McDaniel <nibbleshift@gmail.com>
Contributor
Author
|
Closing this out and submitting a PR to benthos. |
Contributor
Author
|
@Jeffail Can we revisit this PR and discuss a bit more? I submitted a PR in benthos here redpanda-data/connect#1890, but I really don't like my PR for benthos. It results in some sprawling code changes that are just ugly. If you're open to it, I'd like to re-review this PR and possibly make some updates. Making the change in gabs is much more straight-forward and cleaner. |
Contributor
Author
|
Benchmarks main: With cache: |
Contributor
Author
|
Benchmarks: main cache: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This caches DotPathToSlice and JSONPointerToSlice to prevent unnecessary allocations and string replacements on paths/pointers that are frequently looked up.