Repository navigation
Follow the transport Secure rule on the language cookie - #6
Merged
JeanHoccart merged 2 commits intoOct 7, 2026
Merged
Conversation
Language.set now uses the same https / secure_cookies rule as the session and auth cookies, and still leaves the cookie readable from JavaScript.
The parametrized test already proves both directions (https sets Secure, http does not); test_a_prohibition_gate_is_mutation_tested needs the pointer to find it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
Thank you again @sarel-myburgh — same rule as the session cookies, tested end to end on |
JeanHoccart
pushed a commit
that referenced
this pull request
Oct 7, 2026
…le count 262 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2
Language.setnow passessecure=fromresolve_cookie_secure(https → Secure,config.secure_cookiesoverride).httponlystays false. Session and auth cookies are unchanged.