Skip to content

Double Sided Cubes: Add support for Optional Box UV + misc bug fixes#948

Open
JoshieGemFinder wants to merge 4 commits into
JannisX11:masterfrom
JoshieGemFinder:patch/double_sided_cubes
Open

Double Sided Cubes: Add support for Optional Box UV + misc bug fixes#948
JoshieGemFinder wants to merge 4 commits into
JannisX11:masterfrom
JoshieGemFinder:patch/double_sided_cubes

Conversation

@JoshieGemFinder

Copy link
Copy Markdown

Plugin: Double Sided Cubes

Problems:

  1. Double Sided Cubes is not available when Box UVs are the default, even if Per-Face UVs are available and in use.
  2. Inverted cubes will use invalid Box UVs if the original cube was using Box UVs.
  3. Inverted cubes will sometimes be incorrectly named (e.g. inverting "cube1" will create a cube named "cube2 inverted" instead of "cube1 inverted").
  4. Double Sided Cubes has legacy plugin metadata that fails to validate.

Solutions:

  1. Allowed Double Sided Cubes to run when optional Box UVs are supported by the format
  2. Inverted cubes are automatically switched to Per-Face UVs if the original cube was using Box UVs
  3. Base the inverted cube's name on the original cube.name, instead of the name given by cube.duplicate()
  4. Updated plugin metadata to be valid.

Additional Changes:

  • Now places inverted cubes immediately after the original cubes in the outliner, instead of at the bottom of the group.

@JoshieGemFinder

Copy link
Copy Markdown
Author

@SnaveSutit Sorry for the ping, but I believe you made the original plugin. Do you take issue with any of these changes/bugfixes?
I'm more than happy to change anything you don't like to fit with your original vision.

@SnaveSutit

Copy link
Copy Markdown
Contributor

Very good, I approve of these changes. Thank you for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants