Skip to content

Fix Milkchain Rust strict supermajority threshold - #58

Merged
JAPStudios merged 8 commits into
milkchain-rust-corefrom
fix/milkchain-rust-strict-quorum
Nov 13, 2026
Merged

JAPStudios merged 8 commits into
milkchain-rust-corefrom
fix/milkchain-rust-strict-quorum

Conversation

@JAPStudios

@JAPStudios JAPStudios commented Nov 11, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Require strictly more than two-thirds of validator voting power for both block commit and persisted-chain validation.
  • Add boundary tests for three- and six-validator sets: exactly two-thirds is rejected; the next vote is accepted.
  • Roll back the in-memory block if durable ledger persistence fails.
  • Add a regression test proving that failed persistence does not advance the in-memory chain.
  • Correct the persistence-failure test cleanup and preserve the ledger path for cleanup.

Validation

  • Milkchain Rust tests: 6 passed.
  • Python test workflow on this PR branch: passed.
  • Android build workflow on this PR branch: passed.

This pull request targets milkchain-rust-core. It does not merge these changes into main.

@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-11T20:46:11.880078Z
We couldn’t complete this review. Comment @codex review to try again.
fdfeedc PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@JAPStudios
JAPStudios merged commit c5fa036 into milkchain-rust-core Nov 13, 2026
4 checks passed
@JAPStudios
JAPStudios deleted the fix/milkchain-rust-strict-quorum branch November 13, 2026 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant