Skip to content

Add exact multi-currency financial journal - #32

Merged
JAPStudios merged 2 commits into
mainfrom
feature/multi-currency-financial-ledger
Nov 11, 2026
Merged

JAPStudios merged 2 commits into
mainfrom
feature/multi-currency-financial-ledger

Conversation

@JAPStudios

Copy link
Copy Markdown
Owner

What changed

  • Add a persistent double-entry financial journal separate from the Biscuits chain.
  • Register USD with cent precision and JPY with whole-yen precision.
  • Enforce integer minor units, per-currency balancing, non-negative account balances by default, and idempotent posting.
  • Persist journal transactions atomically in SQLite.
  • Add tests for currency precision, cross-currency rejection, balance integrity, overdrafts, idempotency, and persistence.

Scope

This adds an accounting ledger foundation. It does not represent external deposits, custody, settlement, foreign-exchange conversion, or a live bank connection. Biscuits precision remains separately configurable rather than assumed.

@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-10T14:41:34.053676Z
We couldn’t complete this review. Comment @codex review to try again.
4e8ca74 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@JAPStudios JAPStudios closed this Nov 11, 2026
@JAPStudios JAPStudios reopened this Nov 11, 2026
@JAPStudios
JAPStudios merged commit 78e93d9 into main Nov 11, 2026
6 checks passed
@JAPStudios
JAPStudios deleted the feature/multi-currency-financial-ledger branch November 11, 2026 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant