chore: updated dependencies, applied refactor to accommodate new linter rules#7
Open
MDziubinski wants to merge 3 commits intoIteo:mainfrom
Open
chore: updated dependencies, applied refactor to accommodate new linter rules#7MDziubinski wants to merge 3 commits intoIteo:mainfrom
MDziubinski wants to merge 3 commits intoIteo:mainfrom
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
MDziubinski
force-pushed
the
chore/bump_dependencies
branch
from
077303b to
bd5dc26
Compare
lpusz
reviewed
May 9, 2023
lpusz
left a comment
lpusz
left a comment
There was a problem hiding this comment.
In these changes, everything seems okay for me.
Info:
In Slack DM, we decided together to fix all new warnings, coming from the linteo.
MDziubinski
force-pushed
the
chore/bump_dependencies
branch
2 times, most recently
from
62e8616 to
02d287a
Compare
MDziubinski
changed the title
MDziubinski
force-pushed
the
chore/bump_dependencies
branch
from
02d287a to
35e31ca
Compare
lpusz
reviewed
May 11, 2023
There was a problem hiding this comment.
Future.delayed -> Future<void>.delayed without passing empty callback (() {})
packages/injecteo/lib/injecteo.dart
Outdated
| @@ -1,3 +1,4 @@ | |||
| /// Dependency injection configuration using Service Locator patter in a convenient way | |||
There was a problem hiding this comment.
Small typo: patter -> pattern (probably)
MDziubinski
force-pushed
the
chore/bump_dependencies
branch
from
35e31ca to
3f13a53
Compare
kozlowskigrzegorz
approved these changes
May 11, 2023
Contributor
|
Two things to consider:
|
MDziubinski
force-pushed
the
chore/bump_dependencies
branch
3 times, most recently
from
7d7a70b to
abe2b49
Compare
MDziubinski
force-pushed
the
chore/bump_dependencies
branch
from
abe2b49 to
ce824da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.