Add config to display MooLite on the left of the screen - #149
Open
seashairo wants to merge 1 commit into
Open
Conversation
Ishadijcks#138 When this change is applied, the MooLite plugin will have an additional config option for display side, which can be set to either left or right. Right will remain the default, and left will display on the other side using the magic of flex display to render backwards.
seashairo
commented
Feb 10, 2024
| <MooDivider class="border-b-4" /> | ||
|
|
||
| <div class="flex flex-row h-full"> | ||
| <div id="moolite-container" class="flex flex-row h-full"> |
Contributor
Author
There was a problem hiding this comment.
Naming is hard - this might not be the best name, but App seemed even worse
seashairo
commented
Feb 10, 2024
Comment on lines
+80
to
+85
| options: mooLiteDisplaySides.map((side) => { | ||
| return { | ||
| text: toTitleCase(side), | ||
| value: side, | ||
| }; | ||
| }), |
Contributor
Author
There was a problem hiding this comment.
I think this could improve dropdown configs if it was more generic e.g. options: mapArrayToOptions(mooLiteDisplaySides), and save some of the verbosity around using enums alongside their names.
WDYT?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
#138
When this change is applied, the MooLite plugin will have an additional config option for display side, which can be set to either left or right. Right will remain the default, and left will display on the other side using the magic of flex display to render backwards.
Testing instructions
Screenshots
Right
Left