(data-graph): Add authors graph - #469
Open
Luc-Ank wants to merge 8 commits into
Open
Conversation
parmentf
requested changes
Jul 20, 2026
parmentf
left a comment
parmentf
left a comment
Contributor
There was a problem hiding this comment.
| Severity | Count | Description |
|---|---|---|
| Critical | 3 | Pas de validation type, pid non défini possible, injection de chemin |
| Required | 3 | thresh_node non initialisé, logique conditionnelle dispersée, typo autors |
| Optional | 2 | Seuil authors plus lent, hardcoding des valeurs |
Verdict
❌ Request changes — Trois problèmes de criticité bloquent la fusion :
- Validation du paramètre
type— sans validation, n'importe quelle valeur provoque un comportement non testé - Variable
pidnon initialisée —NameErrorgaranti si aucun champPID*n'est présent dans les données - Injection de chemin via
pid— input utilisateur non sanitisé utilisé dansopen()
Ces trois problèmes sont des blockers qui doivent être résolus avant merge. Les autres findings (logique dispersée, typo) sont importants mais peuvent être traités en suivi.
Co-authored-by: François Parmentier <francois.parmentier@gmail.com>
…st-CNRS/web-services into services/data-graph/add-author-graph
parmentf
approved these changes
Jul 28, 2026
parmentf
left a comment
parmentf
left a comment
Contributor
There was a problem hiding this comment.
Plus qu'à faire une version, déployer, changer le port dans le swagger.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.