feat: add has transfer on account flow - #313
Conversation
There was a problem hiding this comment.
Pull request overview
Adds account-scoped sent-transfer detection across Room and legacy Realm storage.
Changes:
- Adds organization/account transfer count queries.
- Adds
hasAccountTransferFlow. - Clarifies excluded-status parameter naming.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
TransferDao.kt |
Adds scoped transfer count flows. |
TransferManager.kt |
Exposes account transfer presence as a boolean flow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @Query( | ||
| """SELECT count(*) FROM TransferDB | ||
| WHERE userOwnerId=:userId AND transferStatus!=:excludedUploadStatus AND transferDirection=:direction AND | ||
| (organizationAccountId=:organizationAccountId OR organizationAccountId IS NULL)""" |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (3)
STDatabase/src/commonMain/kotlin/com/infomaniak/multiplatform_swisstransfer/database/dao/TransferDao.kt:75
- Changing this public parameter name makes existing
expiredTransfersFlow(uploadStatus = ...)source calls fail to compile. RetainuploadStatusto keep this feature release source-compatible.
excludedUploadStatus: TransferStatus = TransferStatus.PENDING_UPLOAD,
STDatabase/src/commonMain/kotlin/com/infomaniak/multiplatform_swisstransfer/database/dao/TransferDao.kt:61
- This rename also breaks existing external calls that use
validTransfersFlow(uploadStatus = ...)against the published database API. Preserve the old argument name unless this is intentionally released as a breaking API change.
excludedUploadStatus: TransferStatus = TransferStatus.PENDING_UPLOAD,
STDatabase/src/commonMain/kotlin/com/infomaniak/multiplatform_swisstransfer/database/dao/TransferDao.kt:42
- Renaming this parameter breaks source compatibility for consumers of the published
STDatabasemodule that calltransfersFlow(uploadStatus = ...); Kotlin named arguments are part of the source API. Keep the existing name (or defer the rename to a documented breaking release).
This issue also appears in the following locations of the same file:
- line 61
- line 75
excludedUploadStatus: TransferStatus = TransferStatus.PENDING_UPLOAD,
Reintroduced by mistake in TransferDao
|
No description provided.