refactor: Remove Transfer v2 interface; replace with toTransferDB() extension

[Copilot]

The Transfer interface in com.infomaniak.multiplatform_swisstransfer.common.interfaces.transfers.v2 was a shared abstraction over both TransferApi and TransferDB, coupling network and database models unnecessarily. It is removed in favour of a direct conversion extension function.

Changes

Deleted

• STCommon/.../interfaces/transfers/v2/Transfer.kt

TransferApi / TransferDB

• Both no longer implement Transfer; override keywords dropped
• TransferDB loses the constructor(transfer: Transfer, ...) secondary constructor
• TransferDB.files narrows from List<File> to List<FileDB>

New: TransferApi.toTransferDB() (STCore)

// STCore/.../mappers/TransferApiV2Ext.kt
internal fun TransferApi.toTransferDB(
    direction: TransferDirection,
    linkId: String?,
    userOwnerId: Long,
    password: String? = null,
    status: TransferStatus = TransferStatus.READY,
): TransferDB

Callers updated

• UploadV2Manager — prepareTransfer() returns TransferApi; getPendingTransferIfAny() returns TransferDB?; both use toTransferDB() internally
• TransferManager.addTransferV2() — uses toTransferDB() instead of the removed constructor

Tests adapted

• DummyTransferForV2 — dummy objects are now TransferDB instances directly instead of anonymous Transfer implementations
• TransfersTest.insertTransfer() — accepts TransferDB, overrides fields via .copy()
• UploadTest — helper methods use DummyTransferForV2.transfer1.copy(...) directly

v1 transfers are untouched.

[Copilot]

Pull request overview

This PR removes the v2 Transfer shared interface that previously coupled network (TransferApi) and database (TransferDB) models, and replaces it with a dedicated TransferApi.toTransferDB() mapper used by v2 upload/download managers.

Changes:

• Remove Transfer v2 abstraction usage: TransferApi/TransferDB no longer implement it, and related constructors/usages are updated.
• Introduce internal fun TransferApi.toTransferDB(...) in STCore and migrate v2 persistence call sites to it.
• Update v2 database tests/datasets to work directly with TransferDB and the updated TransferDB.files typing (List<FileDB>).

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
STNetwork/src/commonMain/kotlin/com/infomaniak/multiplatform_swisstransfer/network/models/transfer/v2/TransferApi.kt	Drops Transfer v2 interface implementation from the network model.
STDatabase/src/commonMain/kotlin/com/infomaniak/multiplatform_swisstransfer/database/models/transfers/v2/TransferDB.kt	Drops Transfer v2 interface implementation, removes constructor-from-Transfer, narrows files to List<FileDB>.
STCore/src/commonMain/kotlin/com/infomaniak/multiplatform_swisstransfer/mappers/TransferApiV2Ext.kt	Adds TransferApi.toTransferDB() mapper extension.
STCore/src/commonMain/kotlin/com/infomaniak/multiplatform_swisstransfer/managers/UploadV2Manager.kt	Updates v2 upload flow to persist via toTransferDB() and adjusts return types.
STCore/src/commonMain/kotlin/com/infomaniak/multiplatform_swisstransfer/managers/TransferManager.kt	Updates v2 add-transfer flow to persist via toTransferDB().
STDatabase/src/commonTest/kotlin/com/infomaniak/multiplatform_swisstransfer/database/v2/dataset/DummyTransferForV2.kt	Updates dummy v2 transfers to be TransferDB instances.
STDatabase/src/commonTest/kotlin/com/infomaniak/multiplatform_swisstransfer/database/v2/TransfersTest.kt	Updates helpers/tests to accept and manipulate TransferDB directly.
STDatabase/src/commonTest/kotlin/com/infomaniak/multiplatform_swisstransfer/database/v2/UploadTest.kt	Updates upload tests to build pending transfers via TransferDB.copy(...).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud