perf: Add index on TransferDB.createdAt to speed up queries - #300
Open
LouisCAD wants to merge 2 commits into
Open
perf: Add index on TransferDB.createdAt to speed up queries#300LouisCAD wants to merge 2 commits into
LouisCAD wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to improve Room query performance by adding an index on TransferDB.createdAt, and updates the Room database schema accordingly.
Changes:
- Add a Room index on
TransferDB.createdAt. - Bump
AppDatabaseversion from 1 → 2 and declare an auto-migration (1 → 2). - Add the exported Room schema for version 2 (
2.json).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| STDatabase/src/commonMain/kotlin/com/infomaniak/multiplatform_swisstransfer/database/models/transfers/v2/TransferDB.kt | Adds a Room index declaration for createdAt on the TransferDB entity. |
| STDatabase/src/commonMain/kotlin/com/infomaniak/multiplatform_swisstransfer/database/DatabaseProvider.kt | Bumps Room DB version to 2 and declares an auto-migration from version 1. |
| STDatabase/schemas/com.infomaniak.multiplatform_swisstransfer.database.AppDatabase/2.json | Adds the generated Room schema snapshot for DB version 2 (includes the new index). |
Comments suppressed due to low confidence (1)
STDatabase/src/commonMain/kotlin/com/infomaniak/multiplatform_swisstransfer/database/models/transfers/v2/TransferDB.kt:29
- The new index is only on
createdAt, but the most frequent queries againstTransferDBalso filter byuserOwnerIdand/ortransferStatuswhile ordering bycreatedAt(seeTransferDao.transfersFlow/validTransfersFlow). A single-columncreatedAtindex may provide limited benefit; consider a composite index that matches the filter + sort pattern (e.g.,(userOwnerId, createdAt)or(userOwnerId, transferStatus, createdAt)) to better support these queries.
@Entity(indices = [Index("createdAt")])
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
sirambd
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.