Skip to content
This repository was archived by the owner on May 4, 2026. It is now read-only.

chore: Add github workflows#54

Merged
sirambd merged 2 commits into
masterfrom
add-github-ci
Mar 26, 2026
Merged

chore: Add github workflows#54
sirambd merged 2 commits into
masterfrom
add-github-ci

Conversation

@sirambd

@sirambd sirambd commented Mar 26, 2026

Copy link
Copy Markdown
Member

No description provided.

sirambd added 2 commits March 26, 2026 10:41
Signed-off-by: Abdourahamane Boinaidi <abdourahamane.boinaidi@infomaniak.com>
Signed-off-by: Abdourahamane Boinaidi <abdourahamane.boinaidi@infomaniak.com>
@github-actions

Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 Security concerns

Secrets exposure via inherit:
The euria-review.yml workflow uses secrets: inherit, granting the reusable workflow access to all repository secrets. While the called workflow is internal to the organization, this pattern violates least-privilege principles and increases risk if the reusable workflow is compromised.

External action with elevated context: The semantic-commit.yml workflow uses pull_request_target (which executes with repository write permissions and access to secrets) combined with an external action gsactions/commit-message-checker@v2. If this third-party action is compromised, it could potentially exfiltrate the GITHUB_TOKEN or modify PRs. Consider pinning to a specific commit hash for supply chain security.

⚡ Recommended focus areas for review

Invalid Action Version

The workflow references actions/checkout@v6.0.2 which does not exist. The latest stable version is v4. This will cause the workflow to fail immediately upon execution.

uses: actions/checkout@v6.0.2
Invalid Action Version

The workflow references actions/checkout@v5.0.0 which does not exist. The latest stable version is v4. This will cause the workflow to fail immediately upon execution.

uses: actions/checkout@v5.0.0
Overly Broad Secrets Access

The workflow uses secrets: inherit which passes all repository secrets to the reusable workflow. If infomaniak/.github/.github/workflows/euria-review.yml@v2 is compromised, it could expose sensitive credentials. Explicitly pass only required secrets instead of inheriting all.

uses: infomaniak/.github/.github/workflows/euria-review.yml@v2
secrets: inherit

@github-actions

Copy link
Copy Markdown

Failed to generate code suggestions for PR

@sirambd
sirambd merged commit ffde6c4 into master Mar 26, 2026
2 checks passed
@sirambd
sirambd deleted the add-github-ci branch March 26, 2026 10:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants