Skip to content

[codex] Fix SCP binder source account scope#46

Merged
InfoSecHack merged 1 commit into
mainfrom
codex/scp-binder-source-account-scope
Jun 4, 2026
Merged

[codex] Fix SCP binder source account scope#46
InfoSecHack merged 1 commit into
mainfrom
codex/scp-binder-source-account-scope

Conversation

@InfoSecHack

Copy link
Copy Markdown
Owner

Summary

  • Fix bind_all_scps to scope SCPs by the edge source/principal account instead of the destination/resource account.
  • Preserve target/resource matching inside bind_scp_to_edge.
  • Add focused cross-account, same-account, resource-pattern, PrincipalArn applicability, source-unavailable, and OU-map regression tests.

Root cause

SCP scope filtering used edge.dst to extract the account for OU/account matching. SCPs govern principals, so cross-account edges could miss source-account SCPs or incorrectly apply target-account SCPs.

Validation

  • python -m pytest -q tests/test_scp_binder.py: 43 passed
  • ./scripts/check.sh: passed
  • ./scripts/test_fast.sh: 1959 passed
  • git diff --check: passed
  • Account/ARN scans: only pre-existing placeholder examples remain in source comments/help
  • Artifact scan: no matches

@InfoSecHack InfoSecHack marked this pull request as ready for review June 4, 2026 19:44
@InfoSecHack InfoSecHack merged commit 65ead14 into main Jun 4, 2026
6 checks passed
@InfoSecHack InfoSecHack deleted the codex/scp-binder-source-account-scope branch June 4, 2026 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant