fix: partial writes support#260
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #260 +/- ##
==========================================
+ Coverage 94.51% 94.53% +0.02%
==========================================
Files 18 18
Lines 2006 2014 +8
==========================================
+ Hits 1896 1904 +8
Misses 82 82
Partials 28 28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Updates partial-write documentation, error detail formatting, and e2e coverage to better reflect how partial writes behave across V2 vs V3 write endpoints.
Changes:
- Document that
AcceptPartialand structuredPartialWriteErrordetails require using the V3 write endpoint (UseV2Api: false), and update the README example payload. - Improve partial-write error detail formatting to include line-numbered messages even when
original_lineis absent. - Extend e2e test logic to support cases where only “non-empty line errors” should be asserted, and add endpoint-specific partial-write test cases.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.md | Clarifies V3 endpoint requirement for structured partial write errors and updates the example. |
| influxdb3/partial_write_error.go | Enhances formatting of partial write error details when OriginalLine is missing. |
| influxdb3/client_e2e_test.go | Adds/adjusts e2e test assertions around partial-write behavior across V2 vs V3 endpoints. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Proposed Changes
Checklist