Skip to content

fix: partial writes support#260

Merged
alespour merged 5 commits into
mainfrom
fix/partial-writes
May 15, 2026
Merged

fix: partial writes support#260
alespour merged 5 commits into
mainfrom
fix/partial-writes

Conversation

@alespour
Copy link
Copy Markdown
Contributor

@alespour alespour commented May 15, 2026

Closes #

Proposed Changes

  • Fixes example - now uses sample input from official documentation
  • Fixes line number parsing

Checklist

  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional

@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.53%. Comparing base (0287213) to head (169ae9c).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
+ Coverage   94.51%   94.53%   +0.02%     
==========================================
  Files          18       18              
  Lines        2006     2014       +8     
==========================================
+ Hits         1896     1904       +8     
  Misses         82       82              
  Partials       28       28              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates partial-write documentation, error detail formatting, and e2e coverage to better reflect how partial writes behave across V2 vs V3 write endpoints.

Changes:

  • Document that AcceptPartial and structured PartialWriteError details require using the V3 write endpoint (UseV2Api: false), and update the README example payload.
  • Improve partial-write error detail formatting to include line-numbered messages even when original_line is absent.
  • Extend e2e test logic to support cases where only “non-empty line errors” should be asserted, and add endpoint-specific partial-write test cases.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
README.md Clarifies V3 endpoint requirement for structured partial write errors and updates the example.
influxdb3/partial_write_error.go Enhances formatting of partial write error details when OriginalLine is missing.
influxdb3/client_e2e_test.go Adds/adjusts e2e test assertions around partial-write behavior across V2 vs V3 endpoints.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread influxdb3/client_e2e_test.go Outdated
@alespour alespour marked this pull request as ready for review May 15, 2026 17:12
@alespour alespour merged commit 6807413 into main May 15, 2026
16 checks passed
@alespour alespour deleted the fix/partial-writes branch May 15, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants