Removed unused SSL Registry and an empty unit#293
Removed unused SSL Registry and an empty unit#293mezen wants to merge 2 commits intoIndySockets:masterfrom
Conversation
rlebeau
left a comment
There was a problem hiding this comment.
I am not aware of any known uses of RegisterSSL()/GSSLRegistry. Indy itself does not make use of GSSLRegistry for anything, other than to register the SSLIOHandler classes in it, but maybe external tools make use of it? I don't know. This may or may not be dead code (it probably is, though).
Turns out, you and I have had this conversation before, a year ago on Gitter. Guess nothing came of it at the time.
Rather than removing this code outright now, I would suggest marking it as 'deprecated' for now, and then I will remove it in Indy 11.
|
Maybe it's time to remove .NET too? |
|
Even if external tools make use of it, they could still create an own list and register the |
|
Support for .NET and pre-Unicode compilers is already slated to be removed in Indy 11 (#131 and #132). It has already been implemented - what is currently in the "Restructure" branch in GitHub will eventually be rebranded as Indy 11, once some pending things have been finalized and the branch is updated with the latest code from my working copy. |
Small code clean ups to remove unused GSSLRegistry
and the empty unit IdServerIOHandlerSSLOpenSSL.