feat: auto-publish Issue when leaderboard #1 changes (#219)#334
Open
zqleslie wants to merge 1 commit into
Open
feat: auto-publish Issue when leaderboard #1 changes (#219)#334zqleslie wants to merge 1 commit into
zqleslie wants to merge 1 commit into
Conversation
…s1988#219) - Add leaderboard_meta.json tracking to gen_leaderboard.py for recording the current Ikalus1988#1 agent and score - In leaderboard_watch.py, compare new Ikalus1988#1 vs previous_meta, auto-create GitHub Issue with leaderboard change notification - Atomic meta file updates with tmp-then-rename pattern - DCO: Signed-off-by
👋 Welcome to MisakaNet!Thanks for opening your first PR! Here's what to expect:
✅ Fix DCO Before CI RunsIf DCO fails, sign your commits with: git rebase --signoff HEAD~N # N = number of commits to fix
git push --forceOr for the latest commit only: git commit --amend --signoff --no-edit
git push --forceCheck the CONTRIBUTING.md guide for more details:
⭐ If you find this project useful, consider starring the repo! |
Ikalus1988
approved these changes
Jul 3, 2026
Ikalus1988
left a comment
Owner
There was a problem hiding this comment.
Clean implementation of #219. Approaches:
gen_leaderboard.pytracks #1 inleaderboard_meta.json(atomic write)leaderboard_watch.pydetects changes + creates notification issue- Also monitors bench leaderboard changes
- Atomic tmp-then-replace pattern for meta file
One minor note: load_meta()/save_meta() are duplicated in both files — could be extracted to a shared util later, but not blocking.
Approved. 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What this does
Implements #219 — automatically creates a GitHub Issue when the leaderboard #1 position changes.
Changes
scripts/gen_leaderboard.py— Addedleaderboard_meta.jsontrackingscripts/leaderboard_watch.py— Integrated#1change detection with Issue creationbench_leaderboard.jsonto check if bench feedback: rag-retrieval-quality ✓ #1 changedleaderboard_meta.jsonfor previous bench feedback: rag-retrieval-quality ✓ #1 comparisonleaderboard_meta.jsonatomically after each rundata/leaderboard_meta.json— Initial empty state file (tracks feedback: rag-retrieval-quality ✓ #1 across runs)How it works
Acceptance Criteria
leaderboard_meta.jsonupdated atomically (tmp-then-rename)Testing
python3 scripts/gen_leaderboard.py --dry-runworks without bench datapython3 scripts/leaderboard_watch.py --dry-runprints notification previewSigned-off-by: zqleslie zqleslie@users.noreply.github.com