fix(deps): regenerate package-lock.json with upstream registry resolutions#176
Merged
Merged
Conversation
…tions Commit 5ba39d8 ("replace file: deps with upstream") rewrote package.json and the root packages."".dependencies section of package-lock.json from `file:` to `^semver`, but left the packages."node_modules/@mdi/js" and packages."node_modules/vue-material-design-icons" entries as `{ "link": true, "resolved": "../../custom-npms/..." }`. Commit d87bf5b ("npm audit fix") preserved that inconsistency. Local installs worked because nc-server/custom-npms/ is checked out on developer machines, so npm ci happily created symlinks to the file:-resolved targets. CI runners have no custom-npms/, so the symlinks dangle, npm ci silently succeeds, and webpack later fails with `Module not found: 'vue-material-design-icons/Close.vue'` and `Module not found: '@mdi/js'`. Regenerated by deleting node_modules and package-lock.json with custom-npms/ moved aside, then running `npm install --no-audit`. Both packages now resolve via registry.npmjs.org with integrity hashes (@mdi/js 7.4.47, vue-material-design-icons 5.3.1 — same versions already declared in package.json). Verified with `npm ci --prefer-offline --no-audit && npm run build` on Node 22 with custom-npms/ absent — webpack compiles with 2 size warnings and 0 errors. Unblocks IONOS-Productivity/nc-server PR #226 (CI cached matrix migration), which exposed the bug by cache-missing the simplesettings build artifact. Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
d87bf5bresolves@mdi/jsandvue-material-design-iconsasfile:links into../../custom-npms/..., even thoughpackage.jsondeclares the upstream semver versions (^7.4.47,^5.3.1). The earlier "replace file: deps with upstream" commit (5ba39d8) only updated the root deps section; thenpm audit fixind87bf5bpreserved the inconsistency becausecustom-npms/was checked out locally when it ran.nc-server/custom-npms/checked out, so npm created working symlinks. CI runners have nocustom-npms/, so the symlinks dangled,npm cisilently succeeded, and webpack failed withModule not found: 'vue-material-design-icons/Close.vue'and friends.node_modules/andpackage-lock.jsonwithcustom-npms/moved aside, thennpm install --no-audit. Both packages now resolve viaregistry.npmjs.orgwith integrity hashes (same versions already declared inpackage.json).Test plan
package-lock.jsonno longer contains"link": truefor@mdi/jsorvue-material-design-icons; both resolve tohttps://registry.npmjs.org/...URLs with integrity hashes.mv custom-npms /tmp/ && rm -rf node_modules && npm ci --prefer-offline --no-audit && npm run build→ webpack compiles with 0 errors (2 informational size warnings onmain.js/entrypoint).build-apps (simplesettings, …)matrix leg goes green.