feat(HDNEXT-1010): intercept file-request send-email via IONOS mailer API by printminion-co · Pull Request #17 · IONOS-Productivity/nc-ionos-processes

printminion-co · 2026-06-12T12:21:35Z

Summary

Replaces ShareCreatedEventListener with BeforeShareMailSentEventListener — the single handler for all share-by-link email delivery via the IONOS internal mail API.

What changed

New: BeforeShareMailSentEventListener handles BeforeShareMailSentEvent fired by ShareByMailProvider.sendEmail() (nc-server PR#262). Calls markMailHandled() unconditionally in every TYPE_EMAIL code path, suppressing native Nextcloud SMTP.
Retired: ShareCreatedEventListener caused double-sends — it called the IONOS API at ShareCreatedEvent time while native SMTP also ran via sendMailNotification().
Simplified: listener constructor drops IUserManager and IURLGenerator — the event now carries pre-computed mailData (senderUserId, fileName, resourceUrl, note, expiration).
psalm.xml: adds ../../apps/sharebymail/lib/Event as extra files so psalm resolves the event class.
tests/stubs/: provides BeforeShareMailSentEvent stub for CI environments without nc-server.

markMailHandled() coverage

Code path	markMailHandled() called?
Non-TYPE_EMAIL share	no — native SMTP still runs
TYPE_EMAIL, empty recipients	yes — suppressed + warning logged
TYPE_EMAIL, missing senderUserId in mailData	yes — suppressed + error logged
TYPE_EMAIL, successful IONOS send	yes — suppressed
TYPE_EMAIL, IONOS send throws	propagates as exception (native send also skipped)

Related PRs

IONOS(sharebymail): add BeforeShare*MailSentEvent dispatched before each mail send (HDNEXT-1010) nc-server#262 — nc-server event classes and dispatch wiring (must merge first)

Test plan

composer test:unit — 14/14 pass
composer cs:fix — no changes
composer psalm — no errors
E2E: regular share by email → IONOS API called once; no double-send
E2E: file request send-email → IONOS API called; no native SMTP

Copilot

Pull request overview

Adds support for routing “send-email” (share email resend) requests through the IONOS mailer API by introducing a new listener for BeforeShareMailNotifiedEvent, while also hardening existing share-created handling against empty recipients to prevent IONOS API errors.

Changes:

Add BeforeShareMailNotifiedEventListener to intercept email resend events and forward them to IonosMailerService.
Add an early-return guard in ShareCreatedEventListener when getSharedWith() is empty.
Extend unit tests and test bootstrap to support the new event (via stub fallback) and validate listener registrations.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
`lib/Listener/ShareCreatedEventListener.php`	Adds empty-recipient guard before sending to the mailer service.
`lib/Listener/BeforeShareMailNotifiedEventListener.php`	New listener for resend/send-email flow, sends share-by-link payload via IONOS mailer.
`lib/AppInfo/Application.php`	Registers the new listener in the app bootstrap.
`tests/Listener/ShareCreatedEventListenerTest.php`	Adds unit test for empty-recipient guard behavior.
`tests/Listener/BeforeShareMailNotifiedEventListenerTest.php`	New unit tests for the new listener’s behavior and error paths.
`tests/stubs/BeforeShareMailNotifiedEvent.php`	Provides test-only fallback event class when not available in the runtime.
`tests/bootstrap.php`	Loads the fallback event stub conditionally for unit tests.
`tests/AppInfo/ApplicationTest.php`	Updates expectations to verify both event listener registrations.
`psalm.xml`	Adds the new event stub file to Psalm stubs to satisfy static analysis.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

 		$context->registerEventListener(ShareCreatedEvent::class, ShareCreatedEventListener::class);
+		$context->registerEventListener(BeforeShareMailNotifiedEvent::class, BeforeShareMailNotifiedEventListener::class);


Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

+use OCA\IonosProcesses\Service\IonosMailerService;
+use OCP\EventDispatcher\Event;
+use OCP\Files\Node;


…lock Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>

…n composer.lock Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>

…it to version ^8.5.52 || ^9.6.34 in composer.lock Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>

…lSentEventListener (HDNEXT-1010) Delivery is now triggered by BeforeShareMailSentEvent fired from inside ShareByMailProvider.sendEmail() (nc-server PR#262). This covers both Manager::createShare() and the sendShareEmail() Controller path with a single listener — eliminating the previous double-send on regular shares. The event carries pre-computed mail data (senderUserId, fileName, resourceUrl, note, expiration) so the listener no longer needs IUserManager or IURLGenerator injections. markMailHandled() is called unconditionally in every TYPE_EMAIL code path so native Nextcloud SMTP is suppressed in all branches. IONOS send failures propagate as exceptions without falling back to SMTP. Non-TYPE_EMAIL share types are not marked handled — native SMTP still runs for them. Retires ShareCreatedEventListener which caused double-sends when combined with the native sendMailNotification() call in Manager::createShare(). Adds tests/stubs/BeforeShareMailSentEvent.php for CI environments without the nc-server sharebymail app. Adds sharebymail event path to psalm.xml for static analysis.

…NEXT-1010) BeforeShareMailSentEvent now exposes named typed getters (getSenderUserId(), getFileName(), getResourceUrl(), getNote(), getExpiration()) instead of a generic getMailData(): array<string,mixed>. Drop all defensive is_string() / null checks in the listener — types are guaranteed by the event class. Remove testMissingSenderUserIdMarkHandledAndLogsError (the corresponding listener guard no longer exists). Update the CI stub and makeEvent() to use the new constructor shape ($templateData with Nextcloud template-convention key names: 'filename', 'link', 'initiator', … instead of the old camelCase event keys).

printminion-co mentioned this pull request Jun 12, 2026

IONOS(sharebymail): add BeforeShare*MailSentEvent dispatched before each mail send (HDNEXT-1010) IONOS-Productivity/nc-server#262

Open

5 tasks

printminion-co force-pushed the HDNEXT-1010-intercept-send-email branch 4 times, most recently from 35d3a58 to f555ea2 Compare June 12, 2026 13:42

printminion-co requested a review from Copilot June 12, 2026 13:45

Copilot started reviewing on behalf of printminion-co June 12, 2026 13:45 View session

Copilot AI reviewed Jun 12, 2026

View reviewed changes

Copilot started work on behalf of printminion-co June 12, 2026 13:52 View session

Copilot finished work on behalf of printminion-co June 12, 2026 13:56

printminion-co force-pushed the HDNEXT-1010-intercept-send-email branch from 24adfb6 to 892cc4c Compare June 12, 2026 14:02

printminion-co requested a review from Copilot June 12, 2026 14:06

Copilot started reviewing on behalf of printminion-co June 12, 2026 14:07 View session

Copilot AI reviewed Jun 12, 2026

View reviewed changes

Comment thread tests/Listener/BeforeShareMailNotifiedEventListenerTest.php Outdated

Comment on lines +16 to +18

use OCA\IonosProcesses\Service\IonosMailerService;

use OCP\EventDispatcher\Event;

use OCP\Files\Node;

printminion-co added 4 commits June 12, 2026 16:14

chore(composer): update nextcloud/ocp to version v33.0.5 in composer.…

27cd439

…lock Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>

chore(composer): update nextcloud/coding-standard to version v1.5.0 i…

7a7ad6a

…n composer.lock Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>

chore(composer): update dependencies in composer.lock to latest versions

c8bdbcb

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>

chore(composer): update guzzlehttp/guzzle to version 7.10.6 and phpun…

fbce3b2

…it to version ^8.5.52 || ^9.6.34 in composer.lock Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>

printminion-co force-pushed the HDNEXT-1010-intercept-send-email branch 2 times, most recently from da3dcb8 to fbce3b2 Compare June 15, 2026 13:46

printminion-co added 2 commits June 15, 2026 15:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(HDNEXT-1010): intercept file-request send-email via IONOS mailer API#17

feat(HDNEXT-1010): intercept file-request send-email via IONOS mailer API#17
printminion-co wants to merge 6 commits into
mainfrom
HDNEXT-1010-intercept-send-email

printminion-co commented Jun 12, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		$context->registerEventListener(ShareCreatedEvent::class, ShareCreatedEventListener::class);
		$context->registerEventListener(BeforeShareMailNotifiedEvent::class, BeforeShareMailNotifiedEventListener::class);

Conversation

printminion-co commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

What changed

markMailHandled() coverage

Related PRs

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

printminion-co commented Jun 12, 2026 •

edited

Loading