Skip to content

Revert Zone.current.print logger workaround - #309

Merged
Rexios80 merged 1 commit into
mainfrom
fix/revert-zone-print-workaround
Jul 21, 2026
Merged

Revert Zone.current.print logger workaround#309
Rexios80 merged 1 commit into
mainfrom
fix/revert-zone-print-workaround

Conversation

@Rexios80

Copy link
Copy Markdown
Member

Summary

  • Reverts the Zone.current.print logger workaround added for flaky isolate tests
  • dart-lang/sdk#63408 is fixed, so top-level print() again honors ZoneSpecification.print after isolate thread migration

Test plan

  • CI passes, especially isolate_test.dart / hive VM tests that capture logger output via runZoned

dart-lang/sdk#63408 is fixed, so print() again respects Zone print
handlers after isolate thread migration and the local workaround is no
longer needed.
@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.59%. Comparing base (66e6c80) to head (e07065a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #309      +/-   ##
==========================================
- Coverage   93.63%   93.59%   -0.05%     
==========================================
  Files          64       64              
  Lines        2623     2622       -1     
==========================================
- Hits         2456     2454       -2     
- Misses        167      168       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Rexios80
Rexios80 merged commit 3d5832e into main Jul 21, 2026
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant