Fix issue 1684: bad stream table formatting for flash#1719
Fix issue 1684: bad stream table formatting for flash#1719Lingyan90 wants to merge 8 commits intoIDAES:mainfrom
Conversation
activated the test for assert stream table contents under class TestBTIdealModular, to fix issue IDAES#1684
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1719 +/- ##
==========================================
+ Coverage 73.80% 73.81% +0.01%
==========================================
Files 399 399
Lines 65373 65369 -4
Branches 11007 11006 -1
==========================================
+ Hits 48249 48253 +4
+ Misses 14609 14605 -4
+ Partials 2515 2511 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bpaul4
left a comment
bpaul4
left a comment
There was a problem hiding this comment.
Just a couple of typos, otherwise looks good.
idaes/models/unit_models/flash.py
Outdated
| stream_attributes[n][k + " " + kname] = quant.m | ||
| stream_attributes["Units"][k + " " + kname] = quant.u | ||
| else: | ||
| # If not using idea separation, we can get outlet state directly |
There was a problem hiding this comment.
| # If not using idea separation, we can get outlet state directly | |
| # If not using ideal separation, we can get outlet state directly |
| "Inlet": { | ||
| "flow_mol": pytest.approx( | ||
| 1.00, rel=1e-4 | ||
| ), # This is different from it's property package's (BT_idea) properties_out value of 100 |
There was a problem hiding this comment.
| ), # This is different from it's property package's (BT_idea) properties_out value of 100 | |
| ), # This is different from its property package's (BT_ideal) properties_out value of 100 |
There was a problem hiding this comment.
updated all the typos in new push
|
@Lingyan90, do you think you can get to this for the Feb (this month's) release? |
Yes, was distracted by other things. The review comments looks straight forward. will push the changes asap. and should be able to be ready for Feb release. |
| "flow_mol": pytest.approx( | ||
| 1.00, rel=1e-4 | ||
| ), # This is different from its property package's (BT_ideal) properties_out value of 100 |
There was a problem hiding this comment.
Why is this value different?
4 participants
Fixes
Fixed a issue that has bad stream table formatting for Flash with Modular Properties (#1684)
Summary/Motivation:
Changes proposed in this PR:
flash.pyunder ideal separation scenariotest_flash.pyLegal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: