Skip to content

feat: Enable rootDeviceHints support for ABI #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Neeraj8418 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Enable rootDeviceHints support for ABI #475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion inventories/default/group_vars/all.yaml.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,8 @@ env:
# - X
# - X
# - X

root_device_hints:

@AmadeusPodvratnik AmadeusPodvratnik May 5, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something valid for all nodes? If yes, than every node de need to contain this hint.
Doc missing. You need to describe this parameter, too.

- ''
# Section 9 - Compute Nodes
compute:
disk_size: 120
Expand Down
21 changes: 18 additions & 3 deletions roles/prepare_configs/templates/agent-config.yaml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,16 @@ hosts:
{% for item in range( env.cluster.nodes.control.ip | length ) %}
- hostname: "{{ env.cluster.nodes.control.hostname[item] }}"
role: master
{% if env.cluster.nodes.control.root_device_hints is defined and env.cluster.nodes.control.root_device_hints[item] %}
rootDeviceHints:
deviceName: "{{ env.cluster.nodes.control.root_device_hints[item] }}"
{% elif env.lpar.storage_group_1 is defined and env.lpar.storage_group_1.dev_num is defined %}
rootDeviceHints:
{%- set dev = env.lpar.storage_group_1.dev_num -%}
{%- set wwpn = env.lpar.storage_group_1.storage_wwpn[0] -%}
{%- set lun = env.lpar.storage_group_1.lun_name %}
deviceName: "/dev/disk/by-path/ccw-{{ dev }}-fc-{{ wwpn }}-lun-{{ lun }}"
{% endif %}
interfaces:
- name: eth0
macAddress: "{{ env.cluster.nodes.control.mac[item] }}"
Expand All @@ -33,12 +43,17 @@ hosts:
- destination: 0.0.0.0/0
next-hop-address: "{{ env.bastion.networking.gateway }}"
next-hop-interface: eth0
table-id: 254
table-id: 254
{% endfor %}

{% if env.cluster.nodes.compute.ip is defined %}
{% for item in range( env.cluster.nodes.compute.ip | length ) %}
- hostname: "{{ env.cluster.nodes.compute.hostname[item] }}"
role: worker
{% if env.cluster.nodes.compute.root_device_hints is defined and env.cluster.nodes.compute.root_device_hints[item] %}
rootDeviceHints:
deviceName: "{{ env.cluster.nodes.compute.root_device_hints[item] }}"
{% endif %}
interfaces:
- name: eth0
macAddress: "{{ env.cluster.nodes.compute.mac[item] }}"
Expand All @@ -63,7 +78,7 @@ hosts:
- destination: 0.0.0.0/0
next-hop-address: "{{ env.bastion.networking.gateway }}"
next-hop-interface: eth0
table-id: 254
table-id: 254
{% endfor %}
{% endif %}
{% endif %}
{% endif %}
Loading