Fix health check test failure caused by stale HealthManager state#377
Open
Fix health check test failure caused by stale HealthManager state#377
Conversation
PartnerConfigMonitorV2Test.testLoadContent creates OptOutSender instances asynchronously and completes before their start() methods can set the HealthManager components to healthy. These stale unhealthy components persist in the singleton HealthManager and cause OptOutServiceVerticleTest getHealthCheck_expectOK to receive 503 instead of 200. Fix by calling HealthManager.instance.reset() in @BeforeClass to clear any accumulated health components from previous tests. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PartnerConfigMonitorV2Test.testLoadContentcreatesOptOutSenderinstances asynchronously insideloadContent(), then immediately callstestContext.completeNow()before the deployments completeOptOutSenderconstructor registers a health component in the singletonHealthManager, initially setting it tofalse;start()normally sets it totrue, but it never runs before Vertx closesHealthManager.instanceand causeOptOutServiceVerticleTest.getHealthCheck_expectOKto receive HTTP 503 instead of 200Test plan
mvn clean test -Dtest=OptOutServiceVerticleTest— should pass with 0 failuresgetHealthCheck_expectOKshould no longer fail🤖 Generated with Claude Code