Skip to content

fix: validate blob list limits #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krowvin merged 1 commit into from
Jul 11, 2026
Merged

fix: validate blob list limits #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions cwmscli/commands/commands_cwms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,10 +671,15 @@ def update_cmd(**kwargs):
show_default=True,
help="Sort descending instead of ascending.",
)
@click.option("--limit", type=int, default=None, help="Max rows to show.")
@click.option(
"--limit",
type=click.IntRange(min=1),
default=None,
help="Max rows to show.",
)
@click.option(
"--page-size",
type=int,
type=click.IntRange(min=1),
default=None,
help="Max rows to request from the blob endpoint. Defaults to --limit if set, otherwise no pagination (all results in one page).",
)
Expand Down Expand Up @@ -837,10 +842,15 @@ def update_cmd(**kwargs):
show_default=True,
help="Sort descending instead of ascending.",
)
@click.option("--limit", type=int, default=None, help="Max rows to show.")
@click.option(
"--limit",
type=click.IntRange(min=1),
default=None,
help="Max rows to show.",
)
@click.option(
"--page-size",
type=int,
type=click.IntRange(min=1),
default=None,
help="Max rows to request from the clob endpoint. Defaults to --limit when set.",
)
Expand Down
60 changes: 60 additions & 0 deletions tests/cli/test_blob_list_validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
from click.testing import CliRunner

from cwmscli.__main__ import cli


def test_blob_list_rejects_zero_limit():
result = CliRunner().invoke(
cli,
[
"blob",
"list",
"--office",
"SWT",
"--api-root",
"https://example.test/cwms-data/",
"--limit",
"0",
],
)

assert result.exit_code == 2
assert "Invalid value for '--limit'" in result.output


def test_blob_list_rejects_negative_page_size():
result = CliRunner().invoke(
cli,
[
"blob",
"list",
"--office",
"SWT",
"--api-root",
"https://example.test/cwms-data/",
"--page-size",
"-1",
],
)

assert result.exit_code == 2
assert "Invalid value for '--page-size'" in result.output


def test_clob_list_rejects_zero_limit():
result = CliRunner().invoke(
cli,
[
"clob",
"list",
"--office",
"SWT",
"--api-root",
"https://example.test/cwms-data/",
"--limit",
"0",
],
)

assert result.exit_code == 2
assert "Invalid value for '--limit'" in result.output
Loading