docs: add BigLinux installation notes#1798
Conversation
* made ghidra project manager to float * Change Ghidra window rule to float true --------- Co-authored-by: Khing <53417443+kRHYME7@users.noreply.github.com>
📝 WalkthroughWalkthroughAdds a Hyprland rule to float Ghidra’s project manager window, updates NVIDIA installation guidance in English and Portuguese docs, and makes the restore script’s shell-change step skip dry-run mode and warn on ChangesGhidra Float Windowrule
Installer Guidance Updates
Restore Shell Login Step
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Scripts/restore_shl.sh`:
- Line 96: The dry-run guard in the restore script should quote the flg_DryRun
variable before the numeric test to avoid word-splitting or globbing from
unexpected environment values. Update the conditional around the flg_DryRun
check in the script’s main guard so the shell test evaluates a safely quoted
value while preserving the existing -ne 1 comparison.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: f36aff3e-9689-4c87-8402-f704facf9410
📒 Files selected for processing (3)
README.mdScripts/restore_shl.shSource/docs/README.pt-br.md
✅ Files skipped from review due to trivial changes (1)
- Source/docs/README.pt-br.md
| if [[ "$(grep "/${USER}:" /etc/passwd | awk -F '/' '{print $NF}')" != "${myShell}" ]]; then | ||
| print_log -sec "SHELL" -stat "change" "shell to ${myShell}..." | ||
| [ ${flg_DryRun} -eq 1 ] || chsh -s "$(which "${myShell}")" | ||
| if [ ${flg_DryRun} -ne 1 ]; then |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Find other unquoted flg_DryRun numeric tests in shell scripts.
fd -e sh . Scripts Configs | xargs rg -n '\[\s+\$\{?flg_DryRun\}?(\s|])'Repository: HyDE-Project/HyDE
Length of output: 1882
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Inspect the relevant section and nearby dry-run checks.
sed -n '85,105p' Scripts/restore_shl.sh
printf '\n---\n'
# Probe how the test behaves with normal, empty, and malformed values.
for v in 0 1 '' '1 2' '*'; do
printf 'value=%q -> ' "$v"
if bash -c 'v=$1; if [ $v -ne 1 ]; then echo yes; else echo no; fi' _ "$v" 2>&1; then
:
fi
doneRepository: HyDE-Project/HyDE
Length of output: 1136
Quote flg_DryRun in this guard. Even with the default value earlier, an unexpected environment value can split or glob before [ evaluates the numeric comparison.
Suggested fix
- if [ ${flg_DryRun} -ne 1 ]; then
+ if [ "${flg_DryRun}" -ne 1 ]; then📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| if [ ${flg_DryRun} -ne 1 ]; then | |
| if [ "${flg_DryRun}" -ne 1 ]; then |
🧰 Tools
🪛 Shellcheck (0.11.0)
[info] 96-96: Double quote to prevent globbing and word splitting.
(SC2086)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@Scripts/restore_shl.sh` at line 96, The dry-run guard in the restore script
should quote the flg_DryRun variable before the numeric test to avoid
word-splitting or globbing from unexpected environment values. Update the
conditional around the flg_DryRun check in the script’s main guard so the shell
test evaluates a safely quoted value while preserving the existing -ne 1
comparison.
Source: Linters/SAST tools
Description
This is intended to make HyDE easier to adopt on Arch-based distros that often ship with an existing desktop setup.
Type of change
Checklist
Additional context
The new notes are intentionally documentation-only so they are easier to review and do not change installer behavior for other Arch-based distributions.
Summary by CodeRabbit
New Features
Documentation
Bug Fixes