Add accessible names to icon-only buttons#70
Open
Elizabethxxx wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several icon-only buttons rendered with no text content and no
aria-label, so screen readers only announced them as generic
"button" controls.
Changes:
("Edit review", "Delete review")
rating buttons have aria-label ("Rate N stars") and aria-pressed
reflecting the selected rating
current action ("Open menu" / "Close menu"), aria-expanded bound
to the open/closed state, and aria-controls pointing to the menu
panel's id
("Search verification status")
No visual or behavioral changes; only accessibility attributes were
added.
Closes #67