add cli options & enhance banner#9
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let (banner_context, server_context) = parse(); | ||
| banner::show_banner(banner_context); | ||
| server::start(server_context).await.unwrap(); |
There was a problem hiding this comment.
Main now prints the “🚀 LanJet Service Started” banner before calling server::start. When the listener fails to bind (e.g. port already in use or insufficient privileges), show_banner has already told the user that the service started even though server::start immediately logs an error and exits. This is a regression from the previous behavior where the start message was emitted only after TcpListener::bind succeeded. Please move the banner output to after the listener has been created so that we only announce success once the server is actually running.
Useful? React with 👍 / 👎.
1 participant
--show-qrcodecli option--local-onlycli option