Skip to content

add check #2361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JFriel wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

add check #2361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c16e2ad
add check
JFriel Jun 8, 2026
3c171d0
update changelog
JFriel Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Allow Merge code to be viewed in UI
- Fix bug with catalogues not becoming project specific when commit from another project
- Improve displayed reason for being unable to make Catalogue Project Specific
- Fix issue with extraction progresses being unable to use temp cohort tables

## [9.2.3] - 2026-05-28
- Fix issue with extractable project data set creation for project specific catalogues
Expand Down
5 changes: 4 additions & 1 deletion Rdmp.Core/DataExport/Checks/SelectedDataSetsChecker.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,8 +305,11 @@ private void ComplainIfUserHasHotSwappedCohort(ICheckNotifier notifier, IExtract

var whereSql = cohort.WhereSQL();

if (!rp.SqlExtracted.Contains(whereSql))

if (!rp.SqlExtracted.Contains(whereSql) && !rp.SqlExtracted.Contains("The ID of the cohort in #"))//If the Cohort starts with a #, then a temp table was used and we can' use it as a check
{
notifier.OnCheckPerformed(new CheckEventArgs(ErrorCodes.CohortSwappedMidExtraction, progress, whereSql));
}
}

/// <summary>
Expand Down
Loading