This repository was archived by the owner on Oct 15, 2020. It is now read-only.
#288 Add query string to force extract_bundle#289
Open
joannelynch92 wants to merge 1 commit intoHewlettPackard:masterfrom
joannelynch92:extract_artifact_bundle
Open
#288 Add query string to force extract_bundle#289joannelynch92 wants to merge 1 commit intoHewlettPackard:masterfrom joannelynch92:extract_artifact_bundle
joannelynch92 wants to merge 1 commit intoHewlettPackard:masterfrom
joannelynch92:extract_artifact_bundle
Conversation
Contributor
|
Great @joannelynch92 We really appreciate you want to contribute to the SDK. Regarding the code, we need a more SDK-like approach, the way you implemented is only showing in an example how to inject the uri with the force flag. I suggest you taking a look at Storage System's get_reachable_ports and remove |
AnushaY1916
pushed a commit
that referenced
this pull request
Mar 2, 2018
…n-adding-osdeploymentsettings-on-sp Fixed #288
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
extract_bundle hangs when a pop up appears on the GUI. This query string will force the call through
Issues Resolved
Possible solution for #288
Check List
$ tox).