fix: add confirm step and undo when revoking creator - #532
Conversation
|
@kolawoleoluwaferanmi014-a11y Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@kolawoleoluwaferanmi014-a11y is attempting to deploy a commit to the David Dada's projects Team on Vercel. A member of the Team first needs to authorize it. |
sshdopey
left a comment
There was a problem hiding this comment.
This PR adds a confirmation step and undo option for revoking creators, directly addressing the linked issue. The changes touch the admin console and toast component, with translations for multiple languages. Great effort on implementing the acceptance criteria! Keep up the awesome work! ❤️
|
Approved! 🎉 I couldn't auto-merge this just yet (it may need a rebase or have a check still running). A maintainer can merge it whenever it's ready. |
sshdopey
left a comment
There was a problem hiding this comment.
This PR adds a confirmation step and undo option when revoking a creator, directly addressing the linked issue. The changes to AdminConsole, Toast, and translations show clear effort and align with the acceptance criteria. Great work! The implementation is functional and thoughtful. Keep up the awesome contributions! ❤️
|
Approved! 🎉 I couldn't auto-merge this just yet (it may need a rebase or have a check still running). A maintainer can merge it whenever it's ready. |
sshdopey
left a comment
There was a problem hiding this comment.
This is a solid effort toward adding a confirmation step and undo for revoking creators. The changes touch the right files, add the necessary UI strings across locales, and implement the confirm and undo logic in the admin console and toast. Even though there are a few minor issues like duplicate keys and a small syntax hiccup, the overall implementation is clear and addresses the issue. Great work! Keep it up! ❤️
sshdopey
left a comment
There was a problem hiding this comment.
This is a solid effort toward adding a confirm step and undo for revoking creators. The changes touch the right files, add translations, and wire up the undo action in the toast. I noticed a few small syntax issues in the diff (like a stray > and some duplicate keys) that might need a quick look, but the overall approach is clear and matches the issue. Nice work! Keep it up! ❤️
|
Approved! 🎉 I couldn't auto-merge this just yet (it may need a rebase or have a check still running). A maintainer can merge it whenever it's ready. |
sshdopey
left a comment
There was a problem hiding this comment.
Hey! Thanks for tackling the confirm step and undo for revoking creators. I can see you've added a confirmation dialog, an undo button in the toast, and updated translations across multiple languages. That's a solid effort toward the issue! The changes look like they address the acceptance criteria. There are a few minor things like duplicate keys in the Arabic file and a small syntax hiccup in the Toast component, but those are easy to clean up later. Great work, and keep it up! ❤️
sshdopey
left a comment
There was a problem hiding this comment.
Hi! Thanks for adding the confirm step and undo for revoking creators. The changes to AdminConsole and Toast look like a solid start, and the i18n strings cover multiple languages. I noticed a few small syntax issues in the diff (like the > in Toast.tsx and the ToastContext,Provider typo) that might need a quick fix, but overall this clearly addresses the issue. Great work! ❤️
|
Approved! 🎉 I couldn't auto-merge this just yet (it may need a rebase or have a check still running). A maintainer can merge it whenever it's ready. |
2 similar comments
|
Approved! 🎉 I couldn't auto-merge this just yet (it may need a rebase or have a check still running). A maintainer can merge it whenever it's ready. |
|
Approved! 🎉 I couldn't auto-merge this just yet (it may need a rebase or have a check still running). A maintainer can merge it whenever it's ready. |
sshdopey
left a comment
There was a problem hiding this comment.
Hi! Thanks for adding the confirm step and undo for revoking creators — this directly addresses the issue and shows real effort. I noticed a few small things like duplicate keys in the Arabic messages and a couple of syntax quirks in Toast.tsx, but those are easy to clean up later. The core functionality is there and the acceptance criteria are met. Great work! ❤️
|
Approved! 🎉 I couldn't auto-merge this just yet (it may need a rebase or have a check still running). A maintainer can merge it whenever it's ready. |
sshdopey
left a comment
There was a problem hiding this comment.
This PR adds a confirmation step before revoking a creator and an undo action in the toast, directly addressing the linked issue. The changes span the admin console and toast component, with translations for multiple languages. There are a few typos and minor issues, but the core functionality is implemented and the effort is clear. Great work! ❤️
|
Thanks for tackling the confirm step and undo for revoking creators! I see real effort here, but there are a few things that look off. The French translation file has duplicate keys and a typo ('Annuler'voquer'), and the Toast.tsx has some syntax errors (e.g., |
|
Approved! 🎉 I couldn't auto-merge this just yet (it may need a rebase or have a check still running). A maintainer can merge it whenever it's ready. |
|
Thanks for tackling the confirm step and undo for revoking creators! I see real effort here, but there are a few things that look off and might need a quick look. The French translations have some duplicated keys and a typo, and the Toast component has a few syntax errors (like |
|
Hi! Thanks for tackling the confirm step and undo for revoking creators — that's a great improvement for the admin flow. I noticed a few things that might need a quick look: the French translations have some duplicated keys and a typo, and there are a couple of typos in Toast.tsx (like |
|
Thanks for tackling the confirm step and undo for revoking creators! I see real effort here, but there are a few things that look off and might need a quick look. The Toast.tsx changes have some syntax issues (e.g., |
Overview
This PR adds a lightweight confirmation step before an admin revokes a creator, plus an undo affordance in the revocation toast. Revocation is now a deliberate two-step action and can be reverted immediately, reducing the risk of accidental creator removal.
Related Issue
Closes the "Add a confirm step when revoking a creator" issue.
Changes
🛡️ Revocation Confirmation & Undo
[MODIFY]
src/screens/admin/AdminConsole.tsx[MODIFY]
src/components/Toast.tsx[MODIFY]
messages/en.json,messages/ar.json,messages/es.json,messages/fr.jsonVerification Results
Closes #397